Page MenuHomePhabricator
Create Task
Maniphest T59900

CirrusSearch: don't spawn a new job to update links if there are no links to update
Closed, ResolvedPublic
Actions

Description

Don't spawn a new job to update links if there are no links to update. This is really common and the jobs don't do any work:

2013-12-02 23:46:30 mw1001 itwiki: cirrusSearchLinksUpdate Kortessem addedLinks=array(0) removedLinks=array(0) primary= STARTING
2013-12-02 23:46:30 mw1001 itwiki: cirrusSearchLinksUpdate Kortessem addedLinks=array(0) removedLinks=array(0) primary= t=0 good
2013-12-02 23:46:30 mw1007 nlwikivoyage: cirrusSearchLinksUpdate Kortessem addedLinks=array(0) removedLinks=array(0) primary= STARTING
2013-12-02 23:46:30 mw1007 nlwikivoyage: cirrusSearchLinksUpdate Kortessem addedLinks=array(0) removedLinks=array(0) primary= t=0 good
2013-12-02 23:46:31 mw1003 itwiki: cirrusSearchLinksUpdate Zoersel addedLinks=array(0) removedLinks=array(0) primary= STARTING
2013-12-02 23:46:31 mw1003 itwiki: cirrusSearchLinksUpdate Zoersel addedLinks=array(0) removedLinks=array(0) primary= t=0 good
2013-12-02 23:46:31 mw1003 itwiki: cirrusSearchLinksUpdate Lista_degli_artisti_musicali_italiani_per_stime_di_vendita addedLinks=array(0) removedLinks=array(0) primary= STARTING
2013-12-02 23:46:31 mw1003 itwiki: cirrusSearchLinksUpdate Lista_degli_artisti_musicali_italiani_per_stime_di_vendita addedLinks=array(0) removedLinks=array(0) primary= t=0 good
2013-12-02 23:46:31 mw1007 nlwikivoyage: cirrusSearchLinksUpdate Wellen addedLinks=array(0) removedLinks=array(0) primary= STARTING
2013-12-02 23:46:31 mw1007 nlwikivoyage: cirrusSearchLinksUpdate Wellen addedLinks=array(0) removedLinks=array(0) primary= t=0 good
2013-12-02 23:46:34 mw1001 itwiki: cirrusSearchLinksUpdate Fading_Like_a_Flower_(Every_Time_You_Leave) addedLinks=array(0) removedLinks=array(0) primary= STARTING
2013-12-02 23:46:34 mw1001 itwiki: cirrusSearchLinksUpdate Fading_Like_a_Flower_(Every_Time_You_Leave) addedLinks=array(0) removedLinks=array(0) primary= t=0 good
2013-12-02 23:46:37 mw1005 itwiki: cirrusSearchLinksUpdate Fagioli/Mi_piaccion_le_sbarbine addedLinks=array(0) removedLinks=array(0) primary= STARTING
2013-12-02 23:46:37 mw1005 itwiki: cirrusSearchLinksUpdate Fagioli/Mi_piaccion_le_sbarbine addedLinks=array(0) removedLinks=array(0) primary= t=0 good

Version: unspecified
Severity: normal

Details

Reference
bz57900

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:41 AM
• bzimport added a project: CirrusSearch.
• bzimport set Reference to bz57900.
• bzimport added a subscriber: Unknown Object (MLST).
• Manybubbles created this task.Dec 2 2013, 11:47 PM
• Manybubbles added a comment.Dec 3 2013, 1:57 PM

Somewhat related - we should investigate raising the number of link additions and deletes chosen per reindex. This has very low cost.

gerritbot added a comment.Dec 3 2013, 4:09 PM

Change 98845 had a related patch set uploaded by Manybubbles:
Don't spawn to update links if there aren't any

https://gerrit.wikimedia.org/r/98845

gerritbot added a comment.Dec 3 2013, 4:18 PM

Change 98845 merged by jenkins-bot:
Don't spawn to update links if there aren't any

https://gerrit.wikimedia.org/r/98845

• Deskana moved this task from Inbox to Resolved/Invalid/Declined/Legacy on the CirrusSearch board.Apr 20 2015, 4:09 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL