Page MenuHomePhabricator

Going to next image, then previous, quickly enough, will cause the load callbacks to fire and give you the next image
Closed, ResolvedPublic

Description

e.g. I'm on image 1, I go to load image 2 but quickly move back to image 1. When the image 2 load callback fires, it replaces image 1 (which I'm viewing), replaces the metadata, and fails to update the URL. Going to the next image brings me to image 2 again, which is confusing.

Solution: Probably clear all callbacks in this case, somehow. Or check that the image we're loading in the callbacks is the image we're currently on. Or use nonces for image load callbacks so we know which one to listen to.


Version: unspecified
Severity: normal

Details

Reference
bz58055

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:22 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz58055.
bzimport added a subscriber: Unknown Object (MLST).

Change 115591 had a related patch set uploaded by Gilles:
Bugfixes and improvements for the progress bar

https://gerrit.wikimedia.org/r/115591

Change 115591 merged by jenkins-bot:
Bugfixes and improvements for the progress bar

https://gerrit.wikimedia.org/r/115591

Tgr added a comment.Feb 27 2014, 1:38 AM

Can't reproduce anymore, hash, image and metadata are in sync no matter how quickly I page, and I haven't non-fully-loaded images either.

Gilles raised the priority of this task from High to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to High.Dec 4 2014, 11:22 AM