Page MenuHomePhabricator

Deprecate and (in the future) remove all old ways of getting different action tokens
Closed, ResolvedPublic


Let's deprecate and (in the future) remove all old ways of getting different action tokens which are now superseded by the action=tokens API

We could probably deprecate it in 1.23 (adding a warning to API calls using them).

We should probably remove them some time after the 1.19 LTS release stops being supported (it is the last version without the new API). 1.24 or 1.25, I guess.

At some point we should also remove the examples in the documentation using the old style (e.g. [[mw:API:Edit#Token]] and same for every other token) and replace them with new-style ones.

Version: 1.23.0
Severity: minor



Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:26 AM
bzimport set Reference to bz58105.
bzimport added a subscriber: Unknown Object (MLST).

It is sometimes suggested, on the other hand, that we shouldn't remove things just to remove them or to "clean up" an interface. As long as it isn't an undue burden to keep the old way around, is there really a need to get rid of it?

That's not to say that the existing token handling in the API couldn't use cleaning up even if the public interface doesn't change. See bug 45199 for more comments on that.

You're an API guy, if you think it's okay, then I say it's okay too.

If we want to keep the handling, then this bug is just about making the documentation use the new way once we stop supporting 1.19.

I should clarify: I haven't really seen opposition to documenting something as deprecated in favor of the new solution, as long as that doesn't mean someone is going to come around and remove it at some point just because it's been deprecated.

(Whatever we do about this, it probably won't be in 1.23 after all; removing milestone.)

In I2793a3f2dd64a4bebb0b4d065e09af1e9f63fb89, action=tokens was deprecated in favor of action=query&meta=tokens, and everything else was also marked as deprecated.