Page MenuHomePhabricator

Multimedia Viewer: Keyboard shortcut to activate MV active inside VisualEditor
Closed, ResolvedPublic

Description

When ve-activated class is set on the body, it would be lovely to deactivate this feature as it's rather irritating. Think it's Shift+cursor or Ctrl+Shift+cursor or something similar?


Version: master
Severity: normal

Details

Reference
bz58107

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz58107.

This may be because we don't clear keydown listener events on closing the viewer. Patch incomiiiiing

Change 99722 had a related patch set uploaded by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/99722

Change 99722 merged by jenkins-bot:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/99722

Bam. Done. Thanks.

Change 100611 had a related patch set uploaded by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/100611

Change 100611 merged by MarkTraceur:
Move clearInterface things to mw.LightboxInterface

https://gerrit.wikimedia.org/r/100611

We backported this fix to 1.23wmf6, so mediawiki.org and all sister sites should be fixed now.

Gilles moved this task from Untriaged to Done on the Multimedia board.Dec 4 2014, 9:33 AM