Page MenuHomePhabricator

Opening notifications overlay scrolls page to the bottom
Closed, ResolvedPublic

Description

Author: jgonera

Description:
In beta, if you open notifications overlay, the page is scrolled to the bottom. This is caused by div#notifications which is used for toasts.

Proposed solution: start using a prefix for route hashes. Not sure if hashbang (#!) is a good one, since those URLs are not meant to be crawled anyway.


Version: unspecified
Severity: normal

Details

Reference
bz58239

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:36 AM
bzimport added a project: MobileFrontend-beta.
bzimport set Reference to bz58239.
bzimport added a subscriber: Unknown Object (MLST).
bzimport created this task.Dec 9 2013, 10:08 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1491

Ahh I kept seeing this and thought i was going mad - now it all makes sense. Thanks for identifying the problem! :)

I would suggest not using ! but maybe prefixing with the '/' character since these can never be present in ID attributes thus more future proof

e.g. #/notifications

  • Bug 58298 has been marked as a duplicate of this bug. ***

Change 100811 had a related patch set uploaded by Jdlrobson:
Prefix notifications with '/'

https://gerrit.wikimedia.org/r/100811

Change 100811 merged by jenkins-bot:
Prefix notifications with '/'

https://gerrit.wikimedia.org/r/100811