Page MenuHomePhabricator

Move editOptions styling into mediawiki.skinning.interface module
Closed, ResolvedPublic

Description

The styling for the editOptions box when editing a page only really applies to Vector and similar skins, but it's in a global file and loaded after the skin css - so not only does it apply to all skins, it even overrides the styling of other skins unless you add some messy selectors to override the override.

It should probably just be in the shared css for Vector/MonoBook instead.


Version: 1.23.0
Severity: normal

Details

Reference
bz58254

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:37 AM
bzimport set Reference to bz58254.
Isarra created this task.Dec 10 2013, 5:38 AM

What box and what styling? (Screenshot please? :) )

Created attachment 14107
editOptions in vector

It's div id #editOptions. The grey box.

I don't know where the styling actually is, just that it's not in the skin and I couldn't find it. It's what makes it grey like that and adds padding and stuff.

That's not necessarily very good for other skins.

Attached:

Several styles for the edit form are defined in /resources/mediawiki.action/mediawiki.action.edit.styles.css; personally I think they are rather unobtrusive, for all core skins at least.

The particular style we're complaining about here is:

.editOptions {
background-color: #F0F0F0;
border: 1px solid silver;
border-top: none;
padding: 1em 1em 1.5em 1em;
margin-bottom: 2em;
}

I think it's okay, but admittedly I don't make custom skins. I'm not a fan of putting more action- or page-specific styles in shared CSS in general, though, we could use skinStyles here or something.

By the way, you can override these rules by using !important or a higher-specificity selector like #editform .editOptions.

Should probably be in the mediawiki.skinning.interface module with the other stuff intended for monobook, vector, and similar skins. Probably interface.css would be the one to move it to, since it's specifically interface styling.

This way only skins that it would work with anyway will get it, since the catlinks etc also share similar styling and are styled here.

Change 162763 had a related patch set uploaded by Bartosz Dziewoński:
Move editoptions styling to mediawiki.skinning/interface.css

https://gerrit.wikimedia.org/r/162763

Change 162763 merged by jenkins-bot:
Move editoptions styling to mediawiki.skinning/interface.css

https://gerrit.wikimedia.org/r/162763