Page MenuHomePhabricator

[Task] Implement an order-aware MapDiffer
Closed, DeclinedPublic

Details

Reference
bz58274

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:38 AM
bzimport set Reference to bz58274.
bzimport added a subscriber: Unknown Object (MLST).

One problem with implementing this is that following the naive approach (representing a change in order as a remove and an insert operation), both such operations would have the same key in the (Map)Diff, so one would override the other. Also, for the insert operation, it would need some context specifying *where* to insert it.

An alternative approach is to represent the order explicitly as a list of keys, and attach that list as an extra field to the MapDiff.

Note that the class tree based in the Diff class contains some overburdened and some deprecated classes. Some refactoring may be in order.

Also, care must be taken to allow for reliably application of Diffs as patches.

Wikidata crew: This has been highest priority since 2013-12-10. Any news here?

Reopen this to not forget it when not following the issues on GitHub.

(In reply to tobias.gritschacher from comment #4)

Reopen this to not forget it when not following the issues on GitHub.

Is this ticket still "highest priority" which was set half a year ago?

(In reply to tobias.gritschacher from comment #4)

Reopen this to not forget it when not following the issues on GitHub.

Is this ticket still "highest priority" which was set half a year ago? If yes, we might have different interpretations of highest priority. ;)

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 16 2015, 10:13 PM
Jonas renamed this task from Implement an order-aware MapDiffer to [Task] Implement an order-aware MapDiffer.Aug 13 2015, 4:51 PM
Jonas closed this task as Declined.
Jonas claimed this task.
Jonas updated the task description. (Show Details)
Jonas set Security to None.
Jonas added a subscriber: Jonas.

We will create a new task after reconsidering the whole ordering topic