Page MenuHomePhabricator

Apply mw.ui button styles to wpSave, wpPreview, and wpDiff
Closed, DeclinedPublic

Description

Author: swalling

Description:
MediaWiki UI has matured enough that, while it may change in the future, it's being applied to essential parts of Core like login, signup, and search buttons.

At this point I see no reason why we shouldn't apply mw.ui button styles to save, preview, and show changes. I propose that we make save an .mw-ui-button.mw-ui-primary button (so the blue color) while leaving Preview and Show changes grey but increasing the sizing to match Save.


Version: unspecified
Severity: enhancement

Details

Reference
bz58296

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:40 AM
bzimport set Reference to bz58296.

swalling wrote:

(In reply to comment #0)

MediaWiki UI has matured enough that, while it may change in the future, it's
being applied to essential parts of Core like login, signup, and search
buttons.

I forgot to note: they're also on password reset.

swalling wrote:

Adding bug 55554 as a dependency, since I think we should sort that out at the same time or beforehand.

I think this should also be blocked on bug 58297 (which I think needs to be a priority). That way, we don't have two major changes to the most important UI on the site in close succession.

Originally, we were going to try to do this site-wide at once: https://gerrit.wikimedia.org/r/#/c/52169 I'm not sure if we should stick to that (we can probably get it done at the mw.ui hack days, though it may require a while).

(In reply to comment #0)

I propose that we make save an
.mw-ui-button.mw-ui-primary button (so the blue color) while leaving Preview
and Show changes grey but increasing the sizing to match Save.

I'm not sure exactly what you mean. However, I think we should use the appropriate mw.ui classes for all of them, including the secondary buttons.

Per comment 3, we should decide whether to do it all at once, or piece by piece like this. I sent an email to https://lists.wikimedia.org/mailman/listinfo/design about this.

Change 116725 had a related patch set uploaded by Deepali:
Apply mw.ui button styles to wpSave, wpPreview, and wpDiff

https://gerrit.wikimedia.org/r/116725

Change 116783 had a related patch set uploaded by Deepali:
Add appropriate mw-ui button styles to Save, Preview, Show changes and cancel buttons.

https://gerrit.wikimedia.org/r/116783

Change 116783 abandoned by Mattflaschen:
Add appropriate mw-ui button styles to Save, Preview, Show changes and cancel buttons.

Reason:
Abandoning duplicate change

https://gerrit.wikimedia.org/r/116783

matmarex closed this task as Declined.Oct 27 2015, 9:34 PM
matmarex claimed this task.
matmarex added a subscriber: matmarex.

This is not going to be done, T111088: Convert EditPage.php to use OOUI rather than MW UI is the plan now.