Implement new mediawiki.ui button appearance in core
Closed, ResolvedPublic

Description

There is a new in-progress design/UX for the mediawiki.ui buttons: https://www.mediawiki.org/wiki/File:Agora_specs.pdf . This includes a new appearance and different CSS class names (see http://www.mail-archive.com/design@lists.wikimedia.org/msg00011.html and https://www.mediawiki.org/wiki/Wikimedia_Foundation_Design/Agora_Control_Library/Behavior).

These updated styles and class names need to be implemented in core. This blocks bug 54360, but can be done before bigger parts of that (e.g. mediawiki.ui dialogs).


Version: 1.23.0
Severity: normal

bzimport added a project: MediaWiki-Interface.Via ConduitNov 22 2014, 2:40 AM
bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz58297.
Mattflaschen created this task.Via LegacyDec 10 2013, 11:31 PM
Jaredzimmerman-WMF added a comment.Via ConduitDec 11 2013, 4:07 AM

We should also do an audit of where Primary should be Constructive and where is should be Progressive. Ideally we'd flip the switch on wikimedia.org first and make changes there so they'll be correct when they go to wikipedia. Should this be a separate bug?

Mattflaschen added a comment.Via ConduitDec 11 2013, 5:04 AM

We can reuse https://gerrit.wikimedia.org/r/#/c/52169 , since it's basically the same thing (albeit started before the new class names were developed).

I suggest we test on Labs (with that changeset checked out), then roll out with the normal process (https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap). We can set up a new Labs instance if none of the current ones are suitable.

Mattflaschen added a comment.Via ConduitDec 11 2013, 5:13 AM

As far as separate bugs, I guess it depends on how we break it up. If we do it all in two commits:

  1. Update core styles and class names and the existing uses in core (there aren't many mw.ui buttons in core, so updating the class names in the HTML is not complicated)
  2. Add mw.ui button classes to the remainder of core.

we should make a separate bug for #2 at some point.

Mattflaschen added a comment.Via ConduitDec 11 2013, 5:14 AM

With that strategy, https://gerrit.wikimedia.org/r/#/c/52169 would be for #2.

gerritbot added a comment.Via ConduitDec 23 2013, 9:58 PM

Change 103494 had a related patch set uploaded by JGonera:
[WIP] Update mediawiki.ui button styles

https://gerrit.wikimedia.org/r/103494

gerritbot added a comment.Via ConduitDec 27 2013, 9:10 AM

Change 104011 had a related patch set uploaded by Spage:
[WIP] Update login and HTMLForm to new design

https://gerrit.wikimedia.org/r/104011

gerritbot added a comment.Via ConduitJan 29 2014, 7:29 PM

Change 103494 merged by jenkins-bot:
Update mediawiki.ui button styles

https://gerrit.wikimedia.org/r/103494

Add Comment