Page MenuHomePhabricator

[Regression] PHP fatal error in /includes/revisiondelete/RevisionDelete.php line 672: Cannot access private property ArchivedFile::$user
Closed, ResolvedPublic

Description

PHP fatal error in /usr/local/apache/common-local/php-1.23wmf6/includes/revisiondelete/RevisionDelete.php line 672:
Cannot access private property ArchivedFile::$user

Reported by an Oversighted while trying to undo an oversight action.


Version: 1.23.0
Severity: normal

Details

Reference
bz58333

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:43 AM
bzimport set Reference to bz58333.
bzimport added a subscriber: Unknown Object (MLST).
Raymond created this task.Dec 11 2013, 4:28 PM

Change 100825 had a related patch set uploaded by Aaron Schulz:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/100825

Change 100825 merged by Brian Wolff:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/100825

Change 102176 had a related patch set uploaded by Legoktm:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/102176

Change 102177 had a related patch set uploaded by Legoktm:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/102177

Per quick discussion with Greg and Tomasz in -operations, this is getting backported to 1.23wmf6 and 1.23wmf7.

Change 102177 merged by jenkins-bot:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/102177

Change 102176 merged by jenkins-bot:
Avoid calling protected File field

https://gerrit.wikimedia.org/r/102176

This is now fixed, backported, and deployed onto all Wikimedia projects.

Thanks to Aaron for the fix, and to Legoktm for backporting.

\o/