Page MenuHomePhabricator

VisualEditor: CE adds linebreaks when pasting into empty lines
Closed, ResolvedPublic

Description

Steps to reproduce:

1.Open the editor for a page which contains link

2.Copy it.

3.Paste it into a new line

4.Save it

Observed Result:
The link is getting merged on to the end of the previous line


Version: unspecified
Severity: normal

Details

Reference
bz58347

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:44 AM
bzimport set Reference to bz58347.
Ryasmeen created this task.Dec 11 2013, 7:34 PM

Test Environment: betalabs
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Example Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=11th_december

Created attachment 14062
Screenshot

Attached:

Modification in steps to reproduce:

step 3 :paste it into a newline on another page or VE

Another issue which I think might be related with this, if not I will file separate bug:

Steps to reproduce:

1.Open the editor for a page

2.Copy a text

3.Paste it into another page

4.Copy an image and paste it onto the next line

Observed Result:
The image does not gets pasted in the other VE.

The issue of link getting merged is still reproducible in betalabs:http://en.wikipedia.beta.wmflabs.org/wiki/December_16th

Modification in steps to reproduce:

1.Open the editor
2.Copy a link or a text
3.Paste it into another VE
4.Observed that the cursor is automatically to the next line though you have not pressed Enter/return
5.Now paste the link or the text again in that position without pressing enter
6.Save the page

Observed Result:
The texts or the links are getting merged in the same line

This latest version of the bug is known issue with CE in Chrome when pasting into a newline.

Change 101905 had a related patch set uploaded by Esanders:
Strip trailing linebreaks on paste due to Chrome bug

https://gerrit.wikimedia.org/r/101905

Change 101905 merged by jenkins-bot:
Strip trailing linebreaks on paste due to Chrome bug

https://gerrit.wikimedia.org/r/101905

I am still getting the issue of two links getting merged in one line after pressing enter after pasting the first link:
http://en.wikipedia.beta.wmflabs.org/wiki/December_17th

Works for me in Chrome and Firefox. Please provide detailed instructions if you can reproduce.

Sorry, here are the detailed steps:

1.Create a page "A" with three links in three consecutive lines.
2.Create another page "B" where you will copy these links to.
3.Copy the first and second link to "B"
4.Save it.
5.Reopen the editor.
6.Now copy the third link and paste it to the third line of "B"
7.Save it.

Observed Result:
The second and the third link in page B is getting merged.

Example Pages:

A:http://en.wikipedia.beta.wmflabs.org/wiki/19th_december_source?veaction=edit
B:http://en.wikipedia.beta.wmflabs.org/wiki/19th_destination

After these steps if you try copying a math function or a link on the third line of Page B , it will also get merged with the two merged links

This is a new bug and something to do with Parsoid and Selser. Filed as bug 58695.

The original issue of this bug has been verified in test 2 with MediaWiki 1.23wmf8
on page:https://test2.wikipedia.org/wiki/19th_december

*The fix for the original issue has been verified in test 2 with mediawiki 1.23wmf8*