Page MenuHomePhabricator

Parsoid-related crashers in production
Closed, ResolvedPublic

Description

Placeholder bug for crashers. Can be split into different bugs upon further investigation

https://gist.github.com/subbuss/23b81fcc5a94242bad1a
/raw/407f472a213f8362f5fefa56ca3a656323bcc0f8/gistfile1.txt


Version: unspecified
Severity: normal

Details

Reference
bz58355

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz58355.
ssastry created this task.Dec 11 2013, 10:54 PM

Change 100954 had a related patch set uploaded by Arlolra:
urllink can parse as an array of tokens

https://gerrit.wikimedia.org/r/100954

The gist seems to have two classes of errors. One is fixed in the above patch. The other can be reproduced in a small test case like,

  • test

<pre style="width:50%;" >
{{hi}}</pre>

A more degenerate case would be,

<pre style="width:50%;" >
{{hi}}</pre>

which seems to spin endlessly.

The culprit is 070efb2f96e8a4a1424f9cbf07188b049327b735, which was also responsible for https://bugzilla.wikimedia.org/show_bug.cgi?id=57650.

I'll look at fixing it tomorrow unless someone gets to it first.

More crashers: I filtered out the two crashers that are already captured in the previous gist

https://gist.github.com/subbuss/7930939/raw/5edab6d8c2a29b0b2b805202deb77a14d34e4d2c/gistfile1.txt

Change 100954 merged by jenkins-bot:
urllink can parse as an array of tokens

https://gerrit.wikimedia.org/r/100954

Change 101138 had a related patch set uploaded by Arlolra:
Pre can end with a space

https://gerrit.wikimedia.org/r/101138

Change 101138 merged by jenkins-bot:
Pre can end with a space

https://gerrit.wikimedia.org/r/101138

Change 101162 had a related patch set uploaded by GWicke:
Bug 58355: Accept html pre with attribute and trailing space

https://gerrit.wikimedia.org/r/101162

Change 101162 merged by jenkins-bot:
Bug 58355: Accept html pre with attribute and trailing space

https://gerrit.wikimedia.org/r/101162

Change 101353 had a related patch set uploaded by GWicke:
urllink can parse as an array of tokens

https://gerrit.wikimedia.org/r/101353

Change 101355 had a related patch set uploaded by GWicke:
Pre can end with a space

https://gerrit.wikimedia.org/r/101355

Change 101356 had a related patch set uploaded by GWicke:
Bug 58355: Accept html pre with attribute and trailing space

https://gerrit.wikimedia.org/r/101356

Change 101356 merged by GWicke:
Bug 58355: Accept html pre with attribute and trailing space

https://gerrit.wikimedia.org/r/101356

Change 101355 merged by GWicke:
Pre can end with a space

https://gerrit.wikimedia.org/r/101355

Change 101353 merged by GWicke:
urllink can parse as an array of tokens

https://gerrit.wikimedia.org/r/101353

There's still the second gist to do here. Looking at it now.

Change 102007 had a related patch set uploaded by Arlolra:
Ensure data.query is present in template request

https://gerrit.wikimedia.org/r/102007

Change 102084 had a related patch set uploaded by Arlolra:
Handle fostered foster boxes

https://gerrit.wikimedia.org/r/102084

Change 102007 merged by GWicke:
Ensure data.query is present in template request

https://gerrit.wikimedia.org/r/102007

Change 102084 merged by jenkins-bot:
Handle fostered foster boxes

https://gerrit.wikimedia.org/r/102084

That last patch addresses the last of the crashers reported in the production logs.