Page MenuHomePhabricator

Misleading error message on edit header conflict
Open, NormalPublic

Description

I was trying to edit the header of Talk:Flow for the first time. But someone else had snuck in and created the header while I was editing. The result of [Preview] or [Save header] is an errorbox

"An error occurred.
The error message received was: Previous revision identifier is missing."

the failing API call is:

{"warnings":{"main":{"*":"Unrecognized parameter: 'workflowId'"}},"flow":{"edit-header":{"result":"error","errors":{"header":{"prev_revision":"Previous revision identifier is missing."}}}}}

(The message would be different if the header already existed and there was an edit conflict.)

The workaround is to reload the page and then edit the page. The fix is edit conflict handling.


Followup: From looking at T94405: The header of User_talk:Amire80 in he.wikipedia cannot be edited, it seems this will lead to flow_revision_unique_parent constraint violation if the header already existed before either user edited. (That is an error, not a legitimate conflict, but it seems like the symptoms would be the same).


Version: master
Severity: normal

Details

Reference
bz58357

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:14 AM
bzimport set Reference to bz58357.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/610, but people from the community are welcome to contribute here and in Gerrit.

Mattflaschen-WMF renamed this task from misleading error message on edit header conflict to Misleading error message on edit header conflict.Mar 30 2015, 9:12 PM
Mattflaschen-WMF updated the task description. (Show Details)
Mattflaschen-WMF set Security to None.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptMar 30 2015, 9:12 PM

This should be similar to flow-error-prev-revision-mismatch, but a different message that is specific to headers.

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 18 2018, 7:01 PM
SBisson moved this task from Inbox to Triaged but Future on the Growth-Team board.Jul 20 2018, 6:08 PM