Page MenuHomePhabricator

Flow: Can't reply to a thread after clicking the Comment(4) link in header.
Closed, ResolvedPublic


Author: sure4us

I was trying to make the topics expand and collapse by clicking the comments button Comments(3) Comments(4) etc.. depending on thread.

Steps to Reproduce:

  1. Scroll to the bottom of any thread. Click in the textbox and note that reply becomes visible as you start typing.
  2. Scroll up the top of that thread. Click the link that says something like " Comments(3)"
  3. Scroll down to the textbox. Start typing. The reply button doesn't highlight as an option.

Actual Results:
I'm unable to hit the 'reply' button after typing, to add my reply to the discussion.

Expected Results:
To be able to hit reply!

Reproducible: Always

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:15 AM
bzimport set Reference to bz58372.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card, but people from the community are welcome to contribute here and in Gerrit.

I'm quite confused by this bug.

It's happening directly because of the "don't let users submit until the textbox has something in it" feature. For some reason it thinks that the textbox is always empty.

When you set a breakpoint on the appropriate spot in ext.flow.editor.none.js, you find that this.$node is a whole bunch of different textareas.

Further investigation indicates that the node that an editor is responsible for is stored inside the editor itself, which is fine until you realise that that editor is reused for all of the nodes. So how does the editor know which of the nodes to check for text in?

Yet, when you open a number of different editors across the page, they all seem to work correctly. So clearly it's working *somehow*.

Adding Matthias to CC, since he wrote most of the editor code.

Yeah, my impression here was wrong. Looking at it now.

Change 105123 had a related patch set uploaded by Bsitu:
Fix issues on clicking "x comments" link

Change 105123 merged by jenkins-bot:
Fix issues on clicking "x comments" link