Stepping through the installer, using Oracle, always returns the error 'config-invalid-db-server-oracle', which is

Invalid database TNS "$1".
Use either "TNS Name" or an "Easy Connect" string ([http://docs.oracle.com/cd/E11882_01/network.112/e10836/naming.htm Oracle Naming Methods])

OracleInstaller::submitConnectForm calls WebInstaller::setVarsFromRequest with each desired form field name as a separate parameter instead of an array in the first parameter as specified in the API documentation.

The bug was introduced in this patch, late in October 2013

https://gerrit.wikimedia.org/r/#/c/88466/

• $newValues = $this->setVarsFromRequest( array( 'wgDBserver', 'wgDBprefix', 'wgDBuser', 'wgDBpassword' ) );

+ $newValues = $this->setVarsFromRequest(
+ 'wgDBserver',
+ 'wgDBprefix',
+ 'wgDBuser',
+ 'wgDBpassword'
+ );

Version: 1.22.0
Severity: major