Page MenuHomePhabricator

Oracle installer uses invalid function invocation and fails
Closed, ResolvedPublic

Description

Stepping through the installer, using Oracle, always returns the error 'config-invalid-db-server-oracle', which is

Invalid database TNS "$1".
Use either "TNS Name" or an "Easy Connect" string ([http://docs.oracle.com/cd/E11882_01/network.112/e10836/naming.htm Oracle Naming Methods])

OracleInstaller::submitConnectForm calls WebInstaller::setVarsFromRequest with each desired form field name as a separate parameter instead of an array in the first parameter as specified in the API documentation.

The bug was introduced in this patch, late in October 2013

https://gerrit.wikimedia.org/r/#/c/88466/

  • $newValues = $this->setVarsFromRequest( array( 'wgDBserver', 'wgDBprefix', 'wgDBuser', 'wgDBpassword' ) );

+ $newValues = $this->setVarsFromRequest(
+ 'wgDBserver',
+ 'wgDBprefix',
+ 'wgDBuser',
+ 'wgDBpassword'
+ );


Version: 1.22.0
Severity: major

Details

Reference
bz58434

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz58434.
bzimport added a subscriber: Unknown Object (MLST).
jayvdb created this task.Dec 13 2013, 3:38 AM

Change 105980 had a related patch set uploaded by Umherirrender:
DatabaseInstaller::setVarsFromRequest needs array

https://gerrit.wikimedia.org/r/105980

Just for reference: I have no oracle to test this patch, I have only fix the point mentioned in comment 0 and I hope that helps.

Change 105985 had a related patch set uploaded by Siebrand:
DatabaseInstaller::setVarsFromRequest needs array

https://gerrit.wikimedia.org/r/105985

No + till merge, according to policy

Change 105980 merged by jenkins-bot:
DatabaseInstaller::setVarsFromRequest needs array

https://gerrit.wikimedia.org/r/105980

Change 105985 merged by jenkins-bot:
DatabaseInstaller::setVarsFromRequest needs array

https://gerrit.wikimedia.org/r/105985

master and release fixed now fixed

hashar removed a subscriber: hashar.May 22 2017, 10:31 AM