Page MenuHomePhabricator

CSSMin's url() value processing doesn't allow parentheses or quotes in the URL
Closed, ResolvedPublic

Description

I have a cross-wiki @import in my personal common.js and common.css pages (on all WMF public wikis) – e.g. https://www.mediawiki.org/w/index.php?title=User:Jdforrester_(WMF)/common.css&oldid=605983 – of the form:

@import url('//meta.wikimedia.org/w/index.php?title=User:Jdforrester (WMF)/global.css&action=raw&ctype=text/css');

Until recent changes unveiled this bug, this worked fine, but now the first parenthesis aborts the import (so it runs as "@import url('//meta.wikimedia.org/w/index.php?title=User:Jdforrester (WMF"), which unsurprisingly 404s.

I can fix this for myself with a bot edit to 1600 pages (fun) to URL-encode the parentheses, but this regression should actually be fixed.


Version: unspecified
Severity: minor

Details

Reference
bz58473

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:22 AM
bzimport set Reference to bz58473.
bzimport added a subscriber: Unknown Object (MLST).

Not a regression, it never did, but previous that was not applied to @imports and thus no one ever noticed.

This is rather low-priority, given that normal people don't have parentheses in their names and don't have @import rules in their personal CSS.

Change 351754 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] CSSMin: Support parenthesis and quotes in url references

https://gerrit.wikimedia.org/r/351754

Change 351754 merged by jenkins-bot:
[mediawiki/core@master] CSSMin: Support parenthesis and quotes in url references

https://gerrit.wikimedia.org/r/351754

matmarex closed this task as Resolved.May 5 2017, 7:01 PM
matmarex removed a project: Patch-For-Review.