Page MenuHomePhabricator

VisualEditor: Computed href in Firefox normalises ' ' to '%20'
Open, MediumPublic

Description

This causes the test 'document with meta elements: data' in ve.dm.MWConverter to fail. Not sure if it is any more serious than that.


Version: unspecified
Severity: normal

Details

Reference
bz58586

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:29 AM
bzimport set Reference to bz58586.

A space is not a valid character in an URL, it must always be percent-encoded. https://en.wikipedia.org/wiki/URL#List_of_allowed_URL_characters

(In reply to comment #1)

A space is not a valid character in an URL, it must always be
percent-encoded.
https://en.wikipedia.org/wiki/URL#List_of_allowed_URL_characters

Are we talking about HTTP or HTML here? If it is HTML, then I'd suggest looking at the relevant HTML5 spec.

(In reply to comment #0)

This causes the test 'document with meta elements: data' in ve.dm.MWConverter
to fail. Not sure if it is any more serious than that.

Are you comparing a HTML serialization or the DOM attribute? A diff in the former is fine, but a diff in the latter would be a bug.

(In reply to comment #3)

(In reply to comment #0)

This causes the test 'document with meta elements: data' in ve.dm.MWConverter
to fail. Not sure if it is any more serious than that.

Are you comparing a HTML serialization or the DOM attribute? A diff in the
former is fine, but a diff in the latter would be a bug.

Actually, a diff in the *percent-decoded* DOM href attribute would be a bug.

We decode all hrefs in the serializer, so to us it makes no difference if it is encoded as %20 or a literal space in HTML.

Is this still a problem? I don't see any such test failing, at least.