Page MenuHomePhabricator

Math creates FSFileBackend in deprecated parameters
Closed, ResolvedPublic

Description

Deprecated: Use of FileBackend::construct called without "wikiID". was
deprecated in MediaWiki 1.23. [Called from FileBackendStore::
construct in
/var/www/w/git/includes/filebackend/FileBackendStore.php at line 68] in
/var/www/w/git/includes/debug/Debug.php on line 301

Deprecated: Use of FileBackend::construct called with non-object
"lockManager". was deprecated in MediaWiki 1.23. [Called from
FileBackendStore::
construct in
/var/www/w/git/includes/filebackend/FileBackendStore.php at line 68] in
/var/www/w/git/includes/debug/Debug.php on line 301


Possibly a good gci bug. Needs to change getBackend(), so that the default
config doesn't create a new FSFileBackend object without specifying wikiID and
a lockManager. The appropriate values are probably just wfWikiId() and new
NullLockManager( array() ) respectively.


Version: unspecified
Severity: minor

Details

Reference
bz58615

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:30 AM
bzimport added projects: Math, good first bug.
bzimport set Reference to bz58615.
Bawolff created this task.Dec 18 2013, 1:36 AM

mails2vichu wrote:

I was not able to clone the repository Math.git by git clone method.
It says

Permission denied (publickey).
fatal: The remote end hung up unexpectedly

Is there any altrenative way to clone the repository ?

That can happen when cloning over ssh, and:
*You haven't added your ssh key to gerrit
*You didn't specify a username in the ssh url, and your git username is different from your local login name. If that happens try
git clone ssh://PUTYOURUSERNAMEHERE@gerrit.wikimedia.org:29418/mediawiki/extensions/Math.git
*You don't have ssh key agent thingy set up properly (This is more likely to happen on windows where all sorts of weird hoops are required to make ssh work)

Vishnu: Please discuss generic development issues (which are not specific to this bug report) in a more generic place, e.g. on IRC or the talk page of http://www.mediawiki.org/wiki/Gerrit/Tutorial . Thanks!

mails2vichu wrote:

Andre Klapper: I already worked on this and with Bawolff's help i was able to edit the page.And i edited the file MathTexvc.php as per the instructions and changed the getbackend(). But the problem occured when i tried to push the branch into gerrit.
I was not able to run the command git review -s/-R/ anything because it says permission denied or could not connect to gerrit.I wish you could figure it out.

physik wrote:

Vishnu: For me the IRC channel MediaWiki-General (http://www.mediawiki.org/wiki/MediaWiki_on_IRC) was helpful to learn how to use git (for mediawiki development).
I think the extension math should move away from storing files. Math 2.0 does not need to access the filesystem at all. Unfortunately there is a review bottleneck for the Math extension.
So all comments on Math 2.0 (https://gerrit.wikimedia.org/r/#/c/85801/) are most welcome.