Page MenuHomePhabricator

Add user_ip fields to multiple flow tables on wmf's extension1db
Closed, ResolvedPublic

Description

Short description:

The current *_user_text fields are being replaced with nullable *_user_ip fields containing the user_ip only for anonymous users. This first half of the schema update adds the *_user_ip fields.

Which wikis are affected:

test, test2, and mediawiki. But the changes are only to tables
on the extension1 cluster's flowdb.

Which tables:

flow_workflow
flow_revision
flow_tree_revision

What is the change to those tables:

ALTER TABLE /*_*/flow_workflow ADD workflow_user_ip varbinary(39) default null;
ALTER TABLE /*_*/flow_tree_revision ADD tree_orig_user_ip varbinary(39) default null;

ALTER TABLE /*_*/flow_revision

ADD rev_user_ip varbinary(39) default null,
ADD rev_mod_user_ip varbinary(39) default null,
ADD rev_edit_user_ip varbinary(39) default null;

Links to gerrit changes and/or other related bug reports.

https://gerrit.wikimedia.org/r/99789

These new columns are not queried directly, only selected as part of other queries. They are 39 bytes to hold either ipv4 or ipv6 addresses formatted as strings, same as they are displayed in the interface. They are superseding the current *_user_text fields which will be dropped from the table after migrations have run.


Version: unspecified
Severity: normal

Details

Reference
bz58650

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:33 AM
bzimport set Reference to bz58650.

Schema changes done.