Page MenuHomePhabricator

Update oversight logs in list of user links in Special:Contributions
Closed, ResolvedPublic

Description

Since the oversight extension is disabled for a few years now (the latest logs are from December 2010), I think it's time to update the list of links concerning the target user which one sees via Special:Contributions. Some projects use different wording (oversighted edits versus hidden user contributions), for example on meta I as a steward/CU see this:

(talk | block | block log | uploads | logs | deleted user contributions | user rights management | rename user | oversighted edits | abuse log | check user IP addresses | recent user checks)

And on commons as a steward/CU I see this:
(talk | block | block log | uploads | logs | deleted user contributions | user rights management | rename user | hidden user contributions | filter log | check user IP addresses | recent user checks)

I would like to see the link to oversighted contributions be updated to the current log (Special:Log/suppress instead of Special:Oversight), so for example, please use https://meta.wikimedia.org/w/index.php?title=Special%3ALog&type=suppress&offender=Trijnstel

instead of https://meta.wikimedia.org/w/index.php?title=Special:Oversight&author=Trijnstel

It has the same results, namely the 'revision author' which is filled in.

The old extension isn't used and the current link to oversighted edits is pretty much redundant; it's not useful to click on it as the latest suppression via oversight was done years ago so I'd appreciate it if someone could update this old link. Thank you very much.


Version: unspecified
Severity: enhancement

Details

Reference
bz59120

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:36 AM
bzimport set Reference to bz59120.

Doesn't seem appropriate to have links to suppression logs as part of the Oversight extension. If done that should be part of core.

(In reply to comment #1)

Doesn't seem appropriate to have links to suppression logs as part of the
Oversight extension. If done that should be part of core.

What do you mean? Or is that something technical?

Well, if the new link to Special:Log/suppress?offender=Trijnstel is edited into the Oversight extension, as soon as the Oversight extension is disabled you no longer see a link to the non-Oversight suppression log. Which doesn't really make sense because the suppression tool won't be gone, Oversight will. It should be part of core, where the suppression stuff is now.

This looks like a duplicate of bug 18598 which would then allow bug 32628.

(In reply to comment #4)

This looks like a duplicate of bug 18598 which would then allow bug 32628.

That is not a duplicate. Bug 18598 refers to converting previously oversighted content to suppressed content; this bug deals with changing the links offered on Special:Contributions.

On the matter itself, I think, as long as bug 18598 is with us, both links should be offered rather than removing the link to the old content, which might still be of use.

Change 104711 had a related patch set uploaded by Legoktm:
Give links to a user's suppressed edits on Special:Contribs

https://gerrit.wikimedia.org/r/104711

Should this depend on bug 32628? Current behavior (with the patch) will provide two links to basically the same content.

Would people find the duplicate links annoying?

(In reply to comment #7)

Would people find the duplicate links annoying?

"People" being oversighters here, that is?

(In reply to comment #8)

(In reply to comment #7)

Would people find the duplicate links annoying?

"People" being oversighters here, that is?

Yes, anyone with the 'suppressionlog' and 'oversight' rights.

(In reply to comment #7)

Should this depend on bug 32628? Current behavior (with the patch) will
provide
two links to basically the same content.
Would people find the duplicate links annoying?

I do not find it annoying but on the other hand:

(In reply to comment #4)

This looks like a duplicate of bug 18598 which would then allow bug 32628.

Can't bug 18598 be solved so that we have one log again (Special:Log/suppress) after which bug 32628 can be done too (disable the old oversight extension)?

(In reply to comment #10)

Can't bug 18598 be solved so that we have one log again
(Special:Log/suppress)

If you can find someone who wants to fix the patch set, yes.

Bug 18598 has been fixed. Can r104711 be merged now?

(In reply to PiRSquared17 from comment #12)

Bug 18598 has been fixed. Can r104711 be merged now?

Wrong link. :\ I meant https://gerrit.wikimedia.org/r/104711

Change 104711 merged by jenkins-bot:
Give links to a user's suppressed edits on Special:Contribs

https://gerrit.wikimedia.org/r/104711

So now core has the suppressed link, I'm wondering if we should remove the OS link from the OS extension or just mark this bug as resolved.

(In reply to Alex Monk from comment #15)

So now core has the suppressed link, I'm wondering if we should remove the
OS link from the OS extension or just mark this bug as resolved.

The OS link should only be removed when the oversighted stuff is transferred to the suppression log and that hasn't happened yet as far as I can see.

(In reply to Trijnstel from comment #16)

(In reply to Alex Monk from comment #15)

So now core has the suppressed link, I'm wondering if we should remove the
OS link from the OS extension or just mark this bug as resolved.

The OS link should only be removed when the oversighted stuff is transferred
to the suppression log and that hasn't happened yet as far as I can see.

The script is there, Wikimedia just hasn't run it because we think it's a better idea to improve it slightly first (make it deal with users who have been renamed since OS took place). I'll remove the link from OS anyway.

Change 117243 had a related patch set uploaded by Alex Monk:
Remove link to OS'd edits from Special:Contributions

https://gerrit.wikimedia.org/r/117243

Change 117243 merged by Bartosz Dziewoński:
Remove link to edits with Oversight from Special:Contributions

https://gerrit.wikimedia.org/r/117243

Status Merged for changes in core and Oversight extension

Meno25 removed a subscriber: Meno25.Oct 3 2016, 5:12 PM