Page MenuHomePhabricator

CirrusSearch: CirrusSearchLinksUpdateJob should contain titles by text rather than title objects
Closed, ResolvedPublic

Description

CirrusSearchLinksUpdateJob should contain titles by text rather than title objects. That should save a bit of space in serialized titles.


Version: unspecified
Severity: normal

Details

Reference
bz59123

Event Timeline

bzimport raised the priority of this task from to High.
bzimport set Reference to bz59123.

When doing this, we'll have to make sure to stay backwards compatible with arrays of tiles on the queue.

I'm seeing us running out of memory trying to push jobs on rare occasions:

#0 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueRedis.php(810): serialize(Array)
#1 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueRedis.php(250): JobQueueRedis->serialize(Array)
#2 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueRedis.php(216): JobQueueRedis->pushBlobs(Object(RedisConnRef), Array)
#3 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueFederated.php(289): JobQueueRedis->doBatchPush(Array, 1)
#4 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueFederated.php(220): JobQueueFederated->tryJobInsertions(Array, Object(HashRing), 0)
#5 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueue.php(340): JobQueueFederated->doBatchPush(Array, 0)
#6 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueue.php(311): JobQueue->batchPush(Array, 0)
#7 /usr/local/apache/common-local/php-1.23wmf7/includes/job/JobQueueGroup.php(129): JobQueue->push(Array)
#8 /usr/local/apache/common-local/php-1.23wmf7/extensions/CirrusSearch/includes/CirrusSearchHooks.php(159): JobQueueGroup->push(Object(CirrusSearchLinksUpdateJob))
#9 [internal function]: CirrusSearchHooks::linksUpdateCompletedHook(Object(LinksUpdate))