Page MenuHomePhabricator
Create Task
Maniphest T61125

Remove SqlBagOStuff::createTables
Closed, ResolvedPublic
Actions

Description

The method SqlBagOStuff::createTables has the comment "Create shard tables. For use from eval.php.", sounds not like something which is needed any more? (at this location)

Or at least remove the version check for mysql 4.1.0 because at the moment 5.0.2 or later is supported

Version: 1.23.0
Severity: enhancement

Details

Reference
bz59125

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:36 AM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz59125.
duplicatebug created this task.Dec 30 2013, 5:24 PM
gerritbot added a comment.Jan 28 2014, 10:04 AM

Change 109859 had a related patch set uploaded by 01tonythomas:
Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables

https://gerrit.wikimedia.org/r/109859

gerritbot added a comment.Jan 28 2014, 7:18 PM

Change 109859 merged by jenkins-bot:
Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables

https://gerrit.wikimedia.org/r/109859

duplicatebug added a comment.Feb 15 2014, 1:28 PM

version check is enough, when the method is still needed, so marking as fixed

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL