Page MenuHomePhabricator

Remove SqlBagOStuff::createTables
Closed, ResolvedPublic

Description

The method SqlBagOStuff::createTables has the comment "Create shard tables. For use from eval.php.", sounds not like something which is needed any more? (at this location)

Or at least remove the version check for mysql 4.1.0 because at the moment 5.0.2 or later is supported


Version: 1.23.0
Severity: enhancement

Details

Reference
bz59125

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:36 AM
bzimport added a project: MediaWiki-General.
bzimport set Reference to bz59125.

Change 109859 had a related patch set uploaded by 01tonythomas:
Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables

https://gerrit.wikimedia.org/r/109859

Change 109859 merged by jenkins-bot:
Removed version check for mysql 4.1.0 from SqlBahOStuff::createTables

https://gerrit.wikimedia.org/r/109859

version check is enough, when the method is still needed, so marking as fixed