Page MenuHomePhabricator

Call to protected method Flow\Model\AbstractRevision::isAllowed() from context 'Flow\NotificationController'
Closed, ResolvedPublic

Description

If I create a new post or reply to my existing post on beta labs, Preview works fine, but [Reply]/[Submit changes] fails with a pink "An error occurred while contacting the server."

The API response is the HTML of a beta labs error

PHP fatal error in /data/project/apache/common-local/php-master/extensions/Flow/includes/Notifications/Controller.php line 411: <br/> 
Call to protected method Flow\Model\AbstractRevision::isAllowed() from context 'Flow\NotificationController'

[01-Jan-2014 23:19:36] Fatal error: Call to protected method Flow\Model\AbstractRevision::isAllowed() from context 'Flow\NotificationController' at /data/project/apache/common-local/php-master/extensions/Flow/includes/Notifications/Controller.php on line 411
Server: i-0000031a
Method: POST
URL: http://en.wikipedia.beta.wmflabs.org/w/api.php
Cookie: vector-nav-p-tb=true; centralnotice_bucket=1-4.2; centralauth_User=Spage+beta; centralauth_Token=3916d0cc134e3e4e611b7a9103d8622e; enwikiUserID=1057; enwikiUserName=Spage+beta; uls-previous-languages=%5B%22en%22%5D; mediaWiki.user.sessionId=krJ3YUsHG70Q7RSo0HZXrqmZ7Iat1Fvp; enwikiSession=d67a5ba1f2b6c6713f3e6128f839ff8a
Backtrace:
#0 /data/project/apache/common-local/php-master/extensions/Flow/includes/Notifications/Controller.php(411): Flow\NotificationController->getCreatorsFromPostIDs()
#1 /data/project/apache/common-local/php-master/extensions/Flow/includes/Notifications/Controller.php(379): Flow\NotificationController::getCreatorsFromPostIDs(Array)
#2 [internal function]: Flow\NotificationController::getDefaultNotifiedUsers(Object(EchoEvent), Array)
#3 /data/project/apache/common-local/php-master/includes/Hooks.php(199): call_user_func_array('Flow\Notificati...', Array)
#4 /data/project/apache/common-local/php-master/includes/GlobalFunctions.php(4032): Hooks::run('EchoGetDefaultN...', Array)
#5 /data/project/apache/common-local/php-master/extensions/Echo/controller/NotificationController.php(300): wfRunHooks('EchoGetDefaultN...', Array)
#6 /data/project/apache/common-local/php-master/extensions/Echo/controller/NotificationController.php(183): EchoNotificationController::getUsersToNotifyForEvent(Object(EchoEvent))
#7 /data/project/apache/common-local/php-master/extensions/Echo/model/Event.php(141): EchoNotificationController::notify(Object(EchoEvent), false)
#8 /data/project/apache/common-local/php-master/extensions/Flow/includes/Notifications/Controller.php(106): EchoEvent::create(Array)
#9 /data/project/apache/common-local/php-master/extensions/Flow/includes/Block/Topic.php(344): Flow\NotificationController->notifyPostChange('flow-post-edite...', Array)
#10 /data/project/apache/common-local/php-master/extensions/Flow/includes/WorkflowLoader.php(204): Flow\Block\TopicBlock->commit()
#11 /data/project/apache/common-local/php-master/extensions/Flow/includes/api/ApiFlow.php(59): Flow\WorkflowLoader->commit(Object(Flow\Model\Workflow), Array)
#12 /data/project/apache/common-local/php-master/includes/api/ApiMain.php(862): ApiFlow->execute()
#13 /data/project/apache/common-local/php-master/includes/api/ApiMain.php(387): ApiMain->executeAction()
#14 /data/project/apache/common-local/php-master/includes/api/ApiMain.php(358): ApiMain->executeActionWithErrorHandling()
#15 /data/project/apache/common-local/php-master/api.php(76): ApiMain->execute()
#16 /data/project/apache/common-local/w/api.php(3): require('/data/project/a...')
#17 {main}


Version: master
Severity: critical
URL: http://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow

Details

Reference
bz59195

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:41 AM
bzimport set Reference to bz59195.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/668, but people from the community are welcome to contribute here and in Gerrit.

This issue is caused by change 102154

Change 104909 had a related patch set uploaded by Werdna:
Fix issue with change 102154, one call to isAllowed was left.

https://gerrit.wikimedia.org/r/104909

Change 104909 merged by jenkins-bot:
Fix issue with change 102154, one call to isAllowed was left.

https://gerrit.wikimedia.org/r/104909