Page MenuHomePhabricator

Autonym name for personal toolbar position under baseline
Closed, ResolvedPublic

Description

ULS is incorrectly positioned in wmf9 (currently deployed on mediawiki.org), see screenshot, taken in Chrome/Ubuntu.


Version: unspecified
Severity: normal

Details

Reference
bz59239

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:17 AM
bzimport set Reference to bz59239.
Eloquence created this task.Jan 3 2014, 3:26 AM

Created attachment 14216
Screenshot (cropped) demonstrating alignment issue

Attached:

Might be caused by bug 59234 making the little person icon disappear?

Confirming in Chrome 31; no problem in Firefox 26.
Adding tentative dependency.

I don't think this is related to bug 59234. This issue is present since dfc40c8f59ca428c9c672a8c8ee9d6f36076a6c0 in ULS which adds autonym class for the trigger.

This causes it to set the height of the text to 14px instead of the 13px of other elements there and misalign it. The issues is present in Chrome 28-32 (all I could test easily) but not in Chrome 16. There is no easily detectable misaglignment in other browsers.

Someone please explain why this issue – misaligment of an element by a couple of pixels, observed only in one browser, having been present for two months – is categorized as a blocker.

Blocker severity is defined as follow (depending on which site you read):

  1. Blocks further development and/or testing work.
  2. Prevents function from being used, no work-around, blocking progress on multiple fronts

(In reply to comment #5)

Someone please explain why this issue – misaligment of an element by a couple
of pixels, observed only in one browser, having been present for two months –
is categorized as a blocker.

Probably due to the connection to bug 59234 which is marked as blocking bug 38865. Given comment 4 the assessment looks superseded.

Looking more closely, the ULS alignment issue on mediawiki.org is indeed exacerbated by bug 59234, due to the user icon no longer showing up. The alignment issue itself is not new, and not a blocker for wmf9, though we should still fix it soon as it's an annoying layout discrepancy.

Change 105643 had a related patch set uploaded by Nikerabbit:
Fix alignment issue of uls trigger

https://gerrit.wikimedia.org/r/105643

Change 105643 merged by jenkins-bot:
Fix alignment issue of ULS trigger

https://gerrit.wikimedia.org/r/105643

From commit summary: The calculated font-height is about 13.5px on Niklas's machine. For some reason the usage of Autonym font sways the rounding of the container height to 14px instead of 13px as for other items. He found out that setting line-height to 1em or 100% makes the trigger size also rounds to 13px, but he can't explain why. He didn't see any change in Modern or Monobook skins.

Change 105670 had a related patch set uploaded by Siebrand:
Fix alignment issue of ULS trigger

https://gerrit.wikimedia.org/r/105670

Change 105670 merged by jenkins-bot:
Fix alignment issue of ULS trigger

https://gerrit.wikimedia.org/r/105670

  • Bug 58244 has been marked as a duplicate of this bug. ***