Page MenuHomePhabricator

Flow: pencil icon appears on moderated topic, and in wrong location
Closed, ResolvedPublic

Description

To reproduce:

  • Hide a topic.

Result:
The "mini-pencil" icon appears before "This topic was hidden by Xxx".

There are three related bugs here:

  1. The real title is hidden. so the pencil icon appears on the left of the moderation action, which looks weird.
  2. If the topic is hidden there's no reason to show the mini-pencil icon for its edited state.
  3. If the only action on the topic is moderation, it's misleading to show the mini-pencil for it.

If we fix 2, 1 goes away. 3 comes back if you later restore the topic: you see the topic title with a mini-pencil icon, but hovering over the mini-pencil does nothing because there isn't really an edit history for the topic, just past revisions due to moderation state changes. That should be a separate bug.


Version: master
Severity: normal

Details

Reference
bz59629

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:16 AM
bzimport set Reference to bz59629.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

The WMF core features team tracks this bug on Mingle card https://mingle.corp.wikimedia.org/projects/flow/cards/682, but people from the community are welcome to contribute here and in Gerrit.

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:39 AM