Page MenuHomePhabricator

Part of HTML comment tag within Heading appears in Search Results and malformed URL. (Wikimedia→lucene-search2?)
Closed, DeclinedPublic

Description

Screenshots illustrating the bug

On en.wikipedia.org [MediaWiki 1.23wmf8 (019de9e)]

Here's some screenshots which illustrate the issue better (also attached):

http://i.imgur.com/a4PpZ8L.png

If an HTML-style comment <!-- like this --> appears in a ==Heading==, the "-->" may appear in the search results, as well as in search URLs.

Not a huge issue, but may point to underlying issues with the parsing of comments, and should probably be fixed.

Note the search link still went to the right page, but failed to find the heading due to the additional "--.3E" in the URL.


Version: unspecified
Severity: minor
Whiteboard: cirrus-fixed

Attached:

Details

Reference
bz59717

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz59717.
bzimport added a subscriber: Unknown Object (MLST).
Pengo created this task.Jan 6 2014, 1:40 PM

CirrusSearch doesn't have this trouble. I've added a regression test to catch it in case it shows up though.

Change 105700 had a related patch set uploaded by Manybubbles:
Clean up tests a bit

https://gerrit.wikimedia.org/r/105700

Change 105700 merged by jenkins-bot:
Clean up tests a bit

https://gerrit.wikimedia.org/r/105700

[No patches left for review here; resetting bug status]

demon added a comment.Apr 22 2014, 8:50 AM

Issue with lsearchd, moving and wontfixing.