Page MenuHomePhabricator

Grey line at top of page when logged out on Main Page
Closed, ResolvedPublic

Description

sign in

Special page titles need to be bold
Sign in
Sign Up
Uploads
Nearby

Watchlist is still missing a title :(

Home page when not logged in has an unnecessary line


Version: unspecified
Severity: normal

Attached:

Details

Reference
bz60066

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:54 AM
bzimport added a project: MobileFrontend-beta.
bzimport set Reference to bz60066.
bzimport added a subscriber: Unknown Object (MLST).

home page not logged in

Attached:

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1619

jgonera wrote:

Titles on special pages already have bold font, watchlist will be tackled in a separate story.

The only one left is: "Home page when not logged in has an unnecessary line"

Okay, so this bug is basically about removing the grey line that appears at the top of the page, when wgMFKeepGoing is disabled and you are logged out which cab be seen here:

http://en.m.wikipedia.beta.wmflabs.org/wiki/Main_Page?mobileaction=beta

Fix on way.

Change 108182 had a related patch set uploaded by Jdlrobson:
Remove superfluous line on the main page when anonymous.

https://gerrit.wikimedia.org/r/108182

Change 108182 merged by jenkins-bot:
Remove superfluous line on the main page when anonymous.

https://gerrit.wikimedia.org/r/108182

  • Bug 60352 has been marked as a duplicate of this bug. ***
  • Bug 60480 has been marked as a duplicate of this bug. ***

Apparently this is not fixed

Jon, can you clarify specifically what is not fixed?

jgonera: jdlrobson, why is https://bugzilla.wikimedia.org/show_bug.cgi?id=60066 not fixed?
[4:04pm] jdlrobson: jgonera: i have no idea
[4:04pm] jdlrobson: either a re-regression or something else
[4:04pm] jgonera: jdlrobson, so why did you say it's not?
[4:04pm] jdlrobson: it's broken still
[4:04pm] jdlrobson: kaldari raised a bug this morning
[4:04pm] jdlrobson: it says so in the comments
[4:04pm] jdlrobson: Duplicate of this bug: 60480
<snip>
[4:05pm] jgonera: jdlrobson, but what specifically? there are multiple items in this bug
<snip>
<snip>
[4:06pm] jdlrobson: Bug https://bugzilla.wikimedia.org/show_bug.cgi?id=60480 may be a less confusing version of this one
<snip>
[4:06pm] jdlrobson: the initial bug report was super confusing and listed various issues

jgonera wrote:

Can't reproduce "Home page when not logged in has an unnecessary line" on latest master or betalabs. Closing.