Page MenuHomePhabricator

Logo change between zh-hans, zh-hant, zh-hk... in Wikivoyage Chinese
Closed, InvalidPublic

Description

The logo in zh.wikivoyage should change according to the language settings like zh-hant, zh-hans, zh-hk... But in every language it still shows the same logo in zh-hans.
Links to different language with the logo:
zh-hans: http://s23.postimg.org/pnnm08knr/zh_hans.png
zh-hant: http://s23.postimg.org/893dryniv/zh_hant.png
zh-hk: http://s23.postimg.org/i8ya7uys7/zh_hk.png


Version: unspecified
Severity: normal
URL: https://zh.wikivoyage.org

Details

Reference
bz60078

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:55 AM
bzimport set Reference to bz60078.

[Moving to "Wikimedia" product as this request is about settings / configuration of the website, not about the codebase of MediaWiki itself.]

I don't think this is a Bugzilla bug; the Chinese Wikipedia appears to be using some sort of JavaScript to present different logos per different language variants.

I haven't been able to find anything in [[zh:MediaWiki:Common.js]], so I think it's cleverly hidden in some gadget; please contact the Chinese Wikipedia community for help.

(In reply to comment #2)

I don't think this is a Bugzilla bug; the Chinese Wikipedia appears to be
using
some sort of JavaScript to present different logos per different language
variants.

I haven't been able to find anything in [[zh:MediaWiki:Common.js]], so I
think
it's cleverly hidden in some gadget; please contact the Chinese Wikipedia
community for help.

No,it isn't.
https://git.wikimedia.org/blob/operations%2Fmediawiki-config/9c822a18d0382d8943691fe76405d8bc7f292161/wmf-config%2FInitialiseSettings.php#L637

https://git.wikimedia.org/blob/operations%2Fmediawiki-config/9c822a18d0382d8943691fe76405d8bc7f292161/wmf-config%2FInitialiseSettings.php#L920

True; we'd need to change the logo to $stdlogo first. Thanks for catching this!

Change 107566 had a related patch set uploaded by Odder:
Enable setting logo per language variant on zh.voy

https://gerrit.wikimedia.org/r/107566

This can't be done in PHP. $stdlogo refers to Wiki.png on site. Ctrl+F for #p-logo in zhwiki's MediaWiki:Common.css.

(In reply to comment #7)

No shit.

What?

To clarify, that patch doesn't do what it claims by "enable the community to set different logos per language variant (zh-hans, zh-hant, etc.)". This is not required by the hack used on zhwiki. If using $stdlogo is expected for easier logo change in the future, that patch works.

Change 107566 abandoned by Odder:
Enable setting logo per language variant on zh.voy

https://gerrit.wikimedia.org/r/107566

Turns out they use CSS[1] for it, not JavaScript as I thought, so they can do with a pre-defined logo.