Page MenuHomePhabricator

Detection of the edit button broken in GettingStarted guided tour 'gettingstartedtasktoolbar'
Closed, ResolvedPublic

Description

Author: swalling

Description:
Screenshot on enwiki

Detection of the 'edit' tab and section edit links is broken currently, probably due to https://gerrit.wikimedia.org/r/#/c/97701/ change in VE.


Version: unspecified
Severity: critical

Attached:

Details

Reference
bz60111

Event Timeline

bzimport raised the priority of this task from to Needs Triage.
bzimport set Reference to bz60111.
bzimport added a subscriber: Unknown Object (MLST).

Specifically, VE's isAvailable used to imply that the preference was also enabled, meaning the VE edit tab would be there.

Now, isAvailable doesn't say anything about the preference. So if you have VE disabled, the tab will be missing, so it can't attach to it, and shows in the center like that.

Change 107631 had a related patch set uploaded by Mattflaschen:
Change how presence of VisualEditor is determined

https://gerrit.wikimedia.org/r/107631

Change 107631 merged by jenkins-bot:
Change how presence of VisualEditor is determined

https://gerrit.wikimedia.org/r/107631

Change 107734 had a related patch set uploaded by Mattflaschen:
Change how presence of VisualEditor is determined

https://gerrit.wikimedia.org/r/107734

Change 107735 had a related patch set uploaded by Mattflaschen:
Change how presence of VisualEditor is determined

https://gerrit.wikimedia.org/r/107735

Change 107734 merged by jenkins-bot:
Change how presence of VisualEditor is determined

https://gerrit.wikimedia.org/r/107734

Change 107735 merged by jenkins-bot:
Change how presence of VisualEditor is determined

https://gerrit.wikimedia.org/r/107735