Page MenuHomePhabricator

Namespace mw.MwEmbedSupport methods
Closed, DeclinedPublic


mw.MwEmbedSupport.js has a large number of methods directly on the mw object.

Several of these are general-sounding (mw.ready, mw.load, mw.inherit), so they can be initially confused with core methods. Others are specific to MwEmbedSupport (e.g. getEmbedPlayerPath), but just shouldn't be on the main object.

I think these should be moved to mw.mwEmbedSupport or somewhere else appropriate.

Version: master
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:52 AM
bzimport set Reference to bz60295.

Some of them I confused several times over the past 3 days. Some of them don't even have namespacing over their RL module names.

On my list of 'todos at some point'. biggest problem is that I'm not really familiar with the Kaltura side of this, so i don't really know what would break their setup.