Page MenuHomePhabricator

:---- should give indent and <hr>
Open, LowPublic

Description

...but gives indent and ---- (4 dashes)


Version: 1.23.0
Severity: normal
URL: https://en.wikipedia.org/w/index.php?title=User:Rezonansowy/sandbox&oldid=592775616

Details

Reference
bz60337

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:55 AM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz60337.
bzimport added a subscriber: Unknown Object (MLST).

Regex for this explicit ask for start of string or newline:

$text = preg_replace( '/(^|\n)-----*/', '\\1<hr />', $text );

in Parser.php::internalParse()

Looks like works as expected

(In reply to comment #1)

Regex for this explicit ask for start of string or newline:
$text = preg_replace( '/(^|\n)-----*/', '\\1<hr />', $text );
in Parser.php::internalParse()
Looks like works as expected

I've made an example, see https://en.wikipedia.org/w/index.php?title=User:Rezonansowy/sandbox&oldid=592775616

I believe it is working as expected, and I don't see why we should change that. Otherwise, it could break existing pages.

(In reply to Ricordisamoa from comment #3)

I believe it is working as expected, and I don't see why we should change
that. Otherwise, it could break existing pages.

No it doesn't, it's a layout bug. Risk that it could break existing pages is very low, nobody codes using layout bugs as a target, besides for similar appearance we have the <nowiki /> tag.
Regards

Rezonansowy raised the priority of this task from Low to Normal.Feb 10 2016, 4:53 PM
Rezonansowy set Security to None.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2016, 4:53 PM

This is a bug in MediaWiki parser, which prevents to comment with lines on page talks for example. Normal priority would be OK here.

Aklapper lowered the priority of this task from Normal to Low.Feb 10 2016, 7:20 PM

@Rezonansowy : Please feel free to increase the priority once somebody plans to work on this task (and is set as assignee). Thanks!
Setting back to low priority to reflect reality.