Page MenuHomePhabricator

Flow: "fetchSubtreeNodeList() on a non-object" errors viewing history of some topics
Closed, ResolvedPublic

Description

Bug 60349 reports database errors (duplicate entry for key 'flow_revision_unique_parent' in flow_revision) when browser tests edit topic titles. I scrolled down in the Flow board https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Flow_QA to load the topic in the screenshot that had a database error. When I click the timestamp in the topic titlebar for either

Title edited0.8243609783129688

(probably the one before the title edit that failed)

Title edited0.42354122292114904

(probably the title whose edit failed), I get a 500 error. The error page has

PHP fatal error in /data/project/apache/common-local/php-master/extensions/Flow/includes/Data/RevisionStorage.php line 550:
Call to a member function fetchSubtreeNodeList() on a non-object

This may be coincidental, but I clicked a bunch of other timestamps in topic titlebars and they show history fine. (The real proof would be to work out the workflow IDs for the other 14 database errors in dberror.log in bug 60349 and attempt to view the topic-history for each of them.) Clicking the mini-pencil icon > Show change for these topics works fine, as does viewing board history.

The 500 URLs are
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow_QA&workflow=050ecd04b9bd5cb204fa02163e0fb68f&action=topic-history
and
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow_QA&workflow=050ecd00e76d5cb204fa02163e0fb68f&action=topic-history

fatal.log contains

#0 /data/project/apache/common-local/php-master/extensions/Flow/includes/Data/RevisionStorage.php(550): Flow\Data\TopicHistoryIndex::backingStoreFindMulti()
#1 /data/project/apache/common-local/php-master/extensions/Flow/includes/Data/ObjectManager.php(1134): Flow\Data\TopicHistoryIndex->backingStoreFindMulti(Array, Array, Array)
#2 /data/project/apache/common-local/php-master/extensions/Flow/includes/Data/ObjectManager.php(243): Flow\Data\FeatureIndex->findMulti(Array)
#3 /data/project/apache/common-local/php-master/extensions/Flow/includes/Data/ObjectManager.php(217): Flow\Data\ObjectLocator->findMulti(Array, Array)
#4 [internal function]: Flow\Data\ObjectLocator->find(Array, Array)
#5 /data/project/apache/common-local/php-master/extensions/Flow/includes/Data/ObjectManager.php(177): call_user_func_array(Array, Array)
...


Version: master
Severity: normal
URL: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Talk:Flow_QA&workflow=050ecd04b9bd5cb204fa02163e0fb68f&action=topic-history

Details

Reference
bz60417

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:01 AM
bzimport set Reference to bz60417.
bzimport added a subscriber: Unknown Object (MLST).

All topics at ee-flow seem to be having this same problem. (I can't find any that work)

Change 109708 had a related patch set uploaded by Bsitu:
fetchSubtreeNodeList() on a non-object

https://gerrit.wikimedia.org/r/109708

Change 109708 merged by jenkins-bot:
fetchSubtreeNodeList() on a non-object

https://gerrit.wikimedia.org/r/109708

Change 109923 had a related patch set uploaded by Physikerwelt:
WIP: Editbutton for math

https://gerrit.wikimedia.org/r/109923

Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptJan 28 2016, 5:57 PM
Ironholds set Security to None.Jan 29 2016, 2:52 PM
Ironholds removed a subscriber: Ironholds.