Make ThrottleOverride handle modifications
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Legoktm
	Jan 25 2014, 8:20 AM

Description

(08:14) root@localhost:[wiki]> select * from throttle_override;
+--------+-----------------------------+-----------------+---------------+----------------+-------------+
| thr_id | thr_type                    | thr_range_start | thr_range_end | thr_expiry     | thr_reason  |
+--------+-----------------------------+-----------------+---------------+----------------+-------------+
|      1 | actcreate,edit,move         | 7F000001        | 7F000001      | 20140127225045 | fsdfjskdfh  |
|      2 | edit,mailpassword,emailuser | 7F000001        | 7F000001      | 20140207225228 | kasdjhfdskj |
+--------+-----------------------------+-----------------+---------------+----------------+-------------+
2 rows in set (0.00 sec)

In this example, I managed to set two different expiries for the 'edit' throttle using the same IP (127.0.0.1).

It should have instead modified the existing row.

Details

Reference: bz60423

	Subject	Repo	Branch	Lines +/-
	Make OverrideThrottle handle modifications of existing throttles	mediawiki/extensions/ThrottleOverride	master	+248 -75

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T202759 Ease the bottleneck in wiki account creation at in-person events
Open	None	T27000 Deploy ThrottleOverride extension to Wikimedia wikis
Resolved	Glaisher	T62423 Make ThrottleOverride handle modifications

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:01 AM

• bzimport added a project: MediaWiki-extensions-ThrottleOverride.

• bzimport set Reference to bz60423.

• bzimport added a subscriber: Unknown Object (MLST).

Legoktm created this task.Jan 25 2014, 8:20 AM

Glaisher renamed this task from ThrottleOverride: Can set multiple expiries for same throttle type to Make ThrottleOverride handle modifications.Mar 21 2015, 8:52 AM

Glaisher claimed this task.

Glaisher updated the task description. (Show Details)

Glaisher set Security to None.

Glaisher edited subscribers, added: Glaisher; removed: Unknown Object (MLST).

Glaisher added a parent task: T27000: Deploy ThrottleOverride extension to Wikimedia wikis.Mar 21 2015, 8:56 AM

Change 198687 had a related patch set uploaded (by Glaisher):
Make OverrideThrottle handle modifications of existing throttles

https://gerrit.wikimedia.org/r/198687

gerritbot added a project: Patch-For-Review.Mar 23 2015, 5:20 AM

Reedy mentioned this in T147362: Use object cache in ThrottleOverride.Oct 4 2016, 9:18 PM

Reedy updated the task description. (Show Details)Oct 4 2016, 9:58 PM

Just needs a useable edit link on the List and should be all good

EddieGP moved this task from Backlog to WMF Deployment Blockers on the MediaWiki-extensions-ThrottleOverride board.Aug 24 2017, 8:37 AM