Page MenuHomePhabricator

MediaWiki:Watchnologintext needs returnto parameter
Closed, ResolvedPublic

Description

If I visit action=watch logged out, I get:


You must be <a href="/wiki/Special:UserLogin" title="Special:UserLogin">logged in</a> to modify your watchlist.

Return to <a href="/wiki/MediaWiki" title="MediaWiki">MediaWiki</a>.


The Special:UserLogin URL should include a returnto parameter so that after logging in/registering the user can at least get back to the original page.


Version: 1.23.0
Severity: normal
URL: https://www.mediawiki.org/wiki/Requests_for_comment/Performance_standards_for_new_features?action=watch

Details

Reference
bz60594

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 2:54 AM
bzimport set Reference to bz60594.
Nemo_bis created this task.Jan 29 2014, 8:46 PM

I hope that the "Return to MediaWiki" part doesn't mean the title= parameter is being ignored completely (so that it defaults to the main page) just because the token is absent or something. In that case, things might be trickier.

mizael_88 wrote:

Returnto is to send you to a specific page. not to perform an action.
read http://www.mediawiki.org/wiki/User:S_Page_(WMF)/Return_to

maybe this is not a bug.

(In reply to Severino Mizael from comment #2)

Returnto is to send you to a specific page. not to perform an action.
read http://www.mediawiki.org/wiki/User:S_Page_(WMF)/Return_to

I read it, but it didn't say anything new to me. :) I don't understand your comment, I'm asking returnto to contain a specific page i.e. the page one was in (this is the standard usage), not "to perform an action".

mizael_88 wrote:

I was wrong earlier.
Now I see that if you use the "log in" option at the top right of the page Returnto works correctly. But if you use this "You must be logged in to modify your watchlist" does not work.

I'll try solve again.

Change 122089 had a related patch set uploaded by Konarak:
MediaWiki:Watchnologintext: Add returnto parameter

https://gerrit.wikimedia.org/r/122089

Change 123837 had a related patch set uploaded by Konarak:
MediaWiki:Watchnologintext: Add returnto parameter

https://gerrit.wikimedia.org/r/123837

Change 122089 abandoned by Konarak:
MediaWiki:Watchnologintext: Add returnto parameter

Reason:
New patch set at https://gerrit.wikimedia.org/r/123837

https://gerrit.wikimedia.org/r/122089

(In reply to Nemo from comment #1)

I hope that the "Return to MediaWiki" part doesn't mean the title= parameter
is being ignored completely (so that it defaults to the main page) just
because the token is absent or something. In that case, things might be
trickier.

No, the user will just have to confirm the action by clicking "OK" one more time. You can test it by looking at e.g. https://en.wikipedia.org/w/index.php?title=Main_Page&action=watch (the link has no token on it, obviously).

Thanks for the patch!

Change 123837 merged by jenkins-bot:
WatchAction: Add 'returnto' and 'returntoquery' to the login link

https://gerrit.wikimedia.org/r/123837