Page MenuHomePhabricator

Flow: update browser tests for UI changes
Closed, ResolvedPublic


The edit menu moved to the action menu. I think as a result three tests fail:

  1. Edit existing title.Edit an existing title

I think this fails because the test has to activate the Actions menu to see "Edit title"

  1. Edit existing title.Edit existing post

This failure is
timed out after 5 seconds, waiting for {:title=>"Edit post", :index=>0, :tag_name=>"a"} to
The edit icon had "Edit post" as its title attribute, but the new ultra-quiet Edit button has only title="Edit". The fix here is just to update the flow_page object element for edit_post_icon, and clean up the naming of this and "Edit post pencil icon" now it's no longer an icon.

  1. Create new topic anonymous.Anon does not see block or actions

The latter failure is
expected #<Watir::Anchor:0x50d5ea2bc230a85c located=true selector={:text=>"Actions", :index=>1, :tag_name=>"a"}> not to exist (RSpec::Expectations::ExpectationNotMetError)

An anonymous user doesn't get hide/delete/suppress actions, so before this change would not get an action menu. But now I think the Actions indicator is present, because s/he can edit a post if s/he created it.

Version: master
Severity: normal



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:59 AM
bzimport set Reference to bz60673.
bzimport added a subscriber: Unknown Object (MLST).

Change 110597 had a related patch set uploaded by Spage:
Fix browser tests for new topic UI

I fixed this yesterday and it is passing on beta labs right now