Page MenuHomePhabricator

Wrong CSS definition causes text bleed at the bottom of Wikisource edit window
Closed, InvalidPublic

Description

Char echos past bottom border

Using the vector skin, last week I switched to the new text editor with the enhanced edit toolbar. In edit mode, the bottom text bleeds into the CharInsert line, or the footer when this is set to be visible. This issue began before version 1.23-git and occurs in the Page and the Main namespace. Please see attached image.

An extensive post can be found here: [https://en.wikisource.org/wiki/User_talk:George_Orwell_III#Edit_box_text_echo_anomaly]


Version: 1.23.0
Severity: major
OS: Windows XP
Platform: PC

Attached:

Character_echo_imprint_on_User_CharInsert.jpg (337×1 px, 73 KB)

Details

Reference
bz61082

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:52 AM
bzimport set Reference to bz61082.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 14540
CharInsert overwritten and not readable

Attached:

Page_ns_echo_on_CharInsert_extension.jpg (558×1 px, 125 KB)

Thanks for taking the time to report this!

(In reply to comment #0)

Using the vector skin, last week I switched to the new text editor with the
enhanced edit toolbar.

What are exact steps to reproduce this on en.wikisource.org plus a link where the problem can still be seen? I have "Show edit toolbar" and "Enable enhanced editing toolbar" enabled on https://en.wikisource.org/wiki/Special:Preferences#mw-prefsection-editing and things look different.

In edit mode, the bottom text bleeds into the CharInsert line

Which browser and version is this about?

Created attachment 14544
displaying edit view without textedit box.

I will keep this page as the example until the issues is resolved.
https://en.wikisource.org/w/index.php?title=Page:Popular_Science_Monthly_Volume_17.djvu/450&action=edit

Attached:

Enhanced_editing_toolbar_enabled_-_show_edit_toolbar_disabled_-_no_textedit_box.jpg (551×1 px, 73 KB)

Created attachment 14545
Screenshot from Firefox 27 and how it looks for me

(In reply to comment #3)

Created attachment 14544 [details]
displaying edit view without textedit box.

How is that related to the screenshot in comment 0 which was about text bleeding at the bottom? I really have problems to follow.

Which browser and version is this about?
Does this also happen with other browsers?

Could you please open the Error Console (or whatever it is called in your browser) and reload the page that you see the problem on? If there is a problem or an error with JavaScript it should be printed in that console.
For more information please see:

Attached:

61082.png (1×1 px, 492 KB)

I am using Firefox v26.0 browser with 32bit Windows XP SP3 OS

There are two issues and although they may be interconnected, perhaps the Bugzilla report should be separated?

Steps taken to reproduce missing textedit box as displayed in the attached image "Enhanced editing toolbar enabled - show edit toolbar disabled - no textedit box.jpg"

  1. I am using this page as an example until this is resolved: [ttps://en.wikisource.org/w/index.php?title=Page:Popular_Science_Monthly_Volume_17.djvu/450&action=edit] But, any document in edit mode in the Page: namespace can be used to duplicate this problem.
  1. In Preferences/Editing options: Select "Enhanced editing toolbar enabled" with "Show edit toolbar" disabled.
  1. Open the above link and there is no text edit box.
  1. In Preferences/Editing options: Select "Enhanced editing toolbar enabled" with "Show edit toolbar" ALSO enabled.
  1. Open the above link and the text edit box is accessible.
  1. The echo or spillover of text into the CharInsert box is noticed when the text box lower border slices through a line of text and the CharInsert is used to insert a character. Please see: CharInsert overwritten and not readable.jpg

Thank you,

Ineuw

I can confirm that when "Show edit toolbar" is disabled, there is no text edit box. This sounds like a separate issue - one bug per report, please, even if they might be related. Please split - this has become confusing enough already.

(In reply to comment #5)

  1. The echo or spillover of text into the CharInsert box is noticed when the

text box lower border slices through a line of text and the CharInsert is
used to insert a character. Please see: CharInsert overwritten and not
readable.jpg

Cannot reproduce as down there, I have "Footer (noinclude):" on your link.
See my screenshot in comment 4.

I would love to split the bug, but which bug should be where? Could you please help me sort this out this one time?

The issue of no edit box occurred to me only after you pointed out that both edit toolbars were enabled. It's then that I remembered why. I apologize for not reporting this earlier.

I can keep editing for the time being using the legacy toolbar which so far haven't caused a text spill into CharInsert.

Thank you.

I have no clue as to how to split this other than clone it. I would love to clean it up and start from the beginning.

Ineuw