Page MenuHomePhabricator

Special:Block tabindex order is incorrect
Closed, ResolvedPublic

Description

Found on svwp, version: 1.23wmf12 (rMW36f1e5cbb12a)

Steps to reproduce:

  1. Use firefox 26
  2. Log in
  3. Open Special:Block
  4. The "target" field (mw-bi-target) should be in focus automatically
  5. Press tab to the "duration" (mw-input-wpExpiry) and select a duration in the dropdown by arrow up/down
  6. Press tab to move to next in tab-index, the marker should now disapear as the freetext field to enter duration (mw-input-wpExpiry-other) is hidden.
  7. Press tab again, the expeted behaviour should be that the reason dropdown (mw-input-wpReason) should be selected. What happens is that the search field (searchInput) is selected

Analysis:

mw-bi-target has tabindex 1
mw-input-wpExpiry & mw-input-wpExpiry-other has tabindex 2

After that there are no more form fields that uses tabindex.

Using firebug and modifying the DOM I note that adding tabindex = 3 to mw-input-wpReason let's me tab to that select element after wp-input-wpExpiry-other.


Version: 1.23.0
Severity: minor

Details

Reference
bz61257

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:03 AM
bzimport set Reference to bz61257.
bzimport added a subscriber: Unknown Object (MLST).
Fluff created this task.Feb 12 2014, 7:40 AM

Change 129946 had a related patch set uploaded by Umherirrender:
Remove tabindex from Special:Block

https://gerrit.wikimedia.org/r/129946

Change 129946 merged by jenkins-bot:
Remove tabindex from Special:Block

https://gerrit.wikimedia.org/r/129946