Page MenuHomePhabricator

SkinAfterBottomScripts doesn't run on mobile (Conflict with Google Analytics Integration extension)
Closed, ResolvedPublic

Description

Referring to Bug https://bugzilla.wikimedia.org/show_bug.cgi?id=45622 it seems to that the Hook already not run on mobile. The Google Analytics Code does not appear in source code of mobile Webpage and the Site (unique identifier, md5 hash of a random string) does not show in Google Analytics account.

Tested on:
MW 1.23wmf11
PHP 5.3.3-7+squeeze18 (cgi-fcgi)
MySQL 5.1.73-1-log
MobileFrontend: Latest development build (beta)
tested Wiki: http://www.droidwiki.de/Spezial:Version

Tested with Google Chrome and UA switch to Android 4.0.3.


Version: unspecified
Severity: normal

Details

Reference
bz61462

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:00 AM
bzimport set Reference to bz61462.
bzimport added a subscriber: Unknown Object (MLST).
Florian created this task.Feb 17 2014, 2:02 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1709

Change 114653 had a related patch set uploaded by MaxSem:
Ensure SkinAfterBottomScripts hook gets called

https://gerrit.wikimedia.org/r/114653

Applied Patch Codeline in used MobileFrontend copy (not loaded the entire Extension again). Tested the extension with same case->GA Script appers in Source code of page and page view is tracked by Google Analytics.

The patch seems to fix the problem. Thanks!

Change 114653 merged by jenkins-bot:
Ensure SkinAfterBottomScripts hook gets called

https://gerrit.wikimedia.org/r/114653

Change 161457 had a related patch set uploaded by Florianschmidtwelzow:
Allow invoking of SkinAfterBottomScripts

https://gerrit.wikimedia.org/r/161457

This is fixed on master so status shouldn't have changed.

Change 161457 merged by MaxSem:
Allow invoking of SkinAfterBottomScripts

https://gerrit.wikimedia.org/r/161457