Page MenuHomePhabricator

Have an i18n CI job that ensures there's a qqq message for each en message
Closed, ResolvedPublic

Description

For projects built with npm (e.g. VE, OOjs UI) this could be relatively easy, but for MW core I imagine it's a bit harder to parse .php files.

(For VE we'd want this blocking merge, but that's a distinct conversation.)


Version: unspecified
Severity: enhancement

Details

Reference
bz61509

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:03 AM
bzimport set Reference to bz61509.

For mediawiki/core I once wrote a test suite that compares messages in messages.inc, en and qqq https://gerrit.wikimedia.org/r/#/c/5550/

They are not passing though and I don't really have the mood to complete this patch though :-(

Change 5550 had a related patch set uploaded by Hashar:
tests to compare En, Qqq and messages.inc

https://gerrit.wikimedia.org/r/5550

Change 125050 had a related patch set uploaded by Jforrester:
Use new banana checker as a linter to avoid lacking qqq messages

https://gerrit.wikimedia.org/r/125050

Done in https://www.npmjs.org/package/grunt-banana-checker – gerrit 125050 adds this to MediaWiki core; gerrit 124069, gerrit 124023 and gerrit 124021 added it to OOjs UI, VisualEditor, and VisualEditor-MediaWiki.

Change 5550 abandoned by Jforrester:
tests to compare En, Qqq and messages.inc

Reason:
Replaced by https://www.npmjs.org/package/grunt-banana-checker now.

https://gerrit.wikimedia.org/r/5550

(In reply to Gerrit Notification Bot from comment #5)

Change 5550 abandoned by Jforrester:
tests to compare En, Qqq and messages.inc
Reason:
Replaced by https://www.npmjs.org/package/grunt-banana-checker now.
https://gerrit.wikimedia.org/r/5550

Sounds good to me :-]

Change 125050 merged by jenkins-bot:
Use new banana checker as a linter to avoid lacking qqq messages

https://gerrit.wikimedia.org/r/125050

Other repositories (i.e. MediaWiki extensions) will be checked using a dedicated Jenkins job. That is the purpose of bug 64045.