Page MenuHomePhabricator

VisualEditor: Revert image |link= hack for Parsoid bug 49844
Closed, InvalidPublic

Description

Parsoid's bug 49844 with link attributes has been fixed.

In https://bugzilla.wikimedia.org/show_bug.cgi?id=49844#c5 James Forrester wrote:

This is worked around (albeit with potentially a bit of a hack) in VisualEditor, so not so important now from VisualEditor's POV.

Now that the parsoid fix has been deployed (for a while now), I'm opening a new bug to revert Visual Editor's hack.


Version: unspecified
Severity: normal

Details

Reference
bz61560

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:06 AM
bzimport set Reference to bz61560.
cscott created this task.Feb 19 2014, 10:06 PM

Change 114352 had a related patch set uploaded by Jforrester:
Revert "Set href attribute of newly inserted image to image title"

https://gerrit.wikimedia.org/r/114352

Change 114352 merged by jenkins-bot:
Revert "Set href attribute of newly inserted image to image title"

https://gerrit.wikimedia.org/r/114352

I believe the reversion is correct. Clarified the spec: https://www.mediawiki.org/w/index.php?title=Parsoid%2FMediaWiki_DOM_spec&diff=931265&oldid=931084
VE's current behavior matches the spec.

Change 119087 had a related patch set uploaded by Cscott:
Clarified the default link for image insertion.

https://gerrit.wikimedia.org/r/119087

Change 119088 had a related patch set uploaded by Jforrester:
Remove commented-out, now-confirmed-as-wrong wrong image insertion code

https://gerrit.wikimedia.org/r/119088

Change 119087 merged by jenkins-bot:
Clarified the default link for image insertion.

https://gerrit.wikimedia.org/r/119087

Change 119088 merged by jenkins-bot:
Remove commented-out, now-confirmed-as-wrong wrong image insertion code

https://gerrit.wikimedia.org/r/119088

As discussed, this wasn't a hack, this was the right thing to do, so INVALIDing this bug.