Page MenuHomePhabricator

LiquidThreads should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz61610

Related Objects

StatusSubtypeAssignedTask
ResolvedPaladox
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:52 AM
bzimport set Reference to bz61610.
bzimport added a subscriber: Unknown Object (MLST).
hashar created this task.Feb 20 2014, 1:37 PM

aditya.iiita102 wrote:

Hi, I have been looking into this bug. I see JShint producing many warnings on the js files but no errors in particular ( except undefined variables, which i assume work fine when all files are used together ). For some fixes I think I need to change rules in the jshintrc. Is that allowed?

Change 121257 had a related patch set uploaded by Adi.iiita:
LiquidThreads should pass jshint

https://gerrit.wikimedia.org/r/121257

Change 121257 merged by jenkins-bot:
LiquidThreads should pass jshint

https://gerrit.wikimedia.org/r/121257

Change 121688 had a related patch set uploaded by Jforrester:
Make jshint voting for LiquidThreads

https://gerrit.wikimedia.org/r/121688

Change 121688 merged by jenkins-bot:
Make jshint voting for LiquidThreads

https://gerrit.wikimedia.org/r/121688

Zuul updated. Thank you everyone!