Page MenuHomePhabricator

Survey should pass jshint
Closed, ResolvedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Related Objects

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
bzimport set Reference to bz61637.
bzimport added a subscriber: Unknown Object (MLST).

Change 121575 had a related patch set uploaded by AalekhN:
Survey should pass Jslint

https://gerrit.wikimedia.org/r/121575

Change 121575 abandoned by Hashar:
Survey should pass Jslint

Reason:
It is still not passing JSHint so the javascript should be fixed in mediawiki/extensions/Survey.git :-)

https://gerrit.wikimedia.org/r/121575

Aklapper triaged this task as Lowest priority.Jan 21 2015, 12:41 AM
Aklapper subscribed.

Change 271494 had a related patch set uploaded (by Paladox):
Fix jslint errors

https://gerrit.wikimedia.org/r/271494

Change 271498 had a related patch set uploaded (by Paladox):
[Survey] Update extension unit tests to no voting and also update other tests on the repo

https://gerrit.wikimedia.org/r/271498

Change 271494 merged by Hashar:
Add npm entry point and fix jshint errors

https://gerrit.wikimedia.org/r/271494

Change 271498 merged by jenkins-bot:
[Survey] Add npm test and also update extension unittest test

https://gerrit.wikimedia.org/r/271498

hashar assigned this task to Paladox.