Page MenuHomePhabricator

"unknown value" and "no value" in diff should be italic
Closed, ResolvedPublic


When a user changes a statement to "no value" or "unknown value" this should be visually different in the diff from other changes. Make them italic.

Sample diff:

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:54 AM
bzimport set Reference to bz61662.
bzimport added a subscriber: Unknown Object (MLST).

Fwiw, this bug was part of why I completely misunderstood a set of diffs and posted this query:

To make it even more obvious, the diff could be

-CustomValue: blah

(that is unified format; obviously the layout is different for two panel diff)

In the above presentation, italics would not be necessary.

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

italics can be weird and not appropriate in some languages (e.g. Japanese [1]) maybe there is another option than italics? or a way for the fonts / css /whatnot to handle emphasis <em> appropriately in given language?


No need for a new design decision, there are already CSS classes in wikibase.css for exactly this case:


Change 195876 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Rework MessageSnakFormatterTest

Change 195877 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Make "unknown value" and "no value" snaks in diffs italic

created T92370 for the issue of italics. (it's one of those super annoyances for me, and probably for people who use wikidata in such languages)

Change 195876 merged by jenkins-bot:
Rework MessageSnakFormatterTest

Change 195877 merged by jenkins-bot:
Make "unknown value" and "no value" snaks in diffs italic

Tobi_WMDE_SW set Security to None.