Extension: https://www.mediawiki.org/wiki/Extension:Popups
Gerrit: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Popups
Version: unspecified
Severity: normal
Extension: https://www.mediawiki.org/wiki/Extension:Popups
Gerrit: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/Popups
Version: unspecified
Severity: normal
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T2503 Create NavigationPopups extension | |||
Resolved | None | T63167 Review and deploy Popups extension (Hovercards feature) to Wikimedia wikis | |||
Resolved | ori | T63742 Architecture/Performance Review for 'Popups' extension |
Here are some numbers that might help-
---------------------+-------------+------------ | ||
Performance | Unminified | Minified |
---------------------+-------------+------------ | ||
JavaScript | 15770 bytes | 6432 bytes |
CSS (Compiled LESS) | 8122 bytes | 6152 bytes |
---------------------+-------------+------------ | ||
Total | 23kb | 12kb |
---------------------+-------------+------------ | ||
Time (in ms) | ||
on 3mbit/s | ~80ms | ~40ms |
---------------------+-------------+------------ |
Apart from the request being made to load the resources a request[1] is made every time a user hovers over a link, this request is aborted if the mouse moves elsewhere. Amongst other things the API call also requests for a 300px thumbnail using the PageImages extension. All successful requests are cached[2] in JavaScript.
[1] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/dbfd8f415e027c75097ebb0c0c6986900a6592a5/resources%2Fext.popups.core.js#L32
[2] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/dbfd8f415e027c75097ebb0c0c6986900a6592a5/resources%2Fext.popups.core.js#L82
[3] http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FPopups.git/dbfd8f415e027c75097ebb0c0c6986900a6592a5/resources%2Fext.popups.core.js#L284
[4] https://bugzilla.wikimedia.org/61880 (PATCH_TO_REVIEW)
[5] https://bugzilla.wikimedia.org/61481 (PATCH_TO_REVIEW)
(In reply to Ori Livneh from comment #3)
Can you project how many users will have this feature enabled?
The project will be considered finished when this is enabled by default for all anonymous users.
Note: We, obviously, need detailed user testing and information on user acceptance before we could even consider this end goal, and we're nowhere near that stage yet. If the intended audience find it annoying, we'd never roll it out. But that's our idealistic end goal. In the interim time, it'll be whoever turns the it on in their beta preferences.
swalling wrote:
(In reply to Dan Garry from comment #5)
(In reply to Ori Livneh from comment #3)
Can you project how many users will have this feature enabled?
The project will be considered finished when this is enabled by default for
all anonymous users.
Yes, we should design this so it is performant enough for all readers to see.
However, the first deployment will be as a Beta Feature, so the upper limit is all registered users on all wikis. This is unlikely however, since all Beta Features are opt-in only. For other popular Beta Features other than VE, we're seeing 5-6k registered users on enwiki, fewer on other wikis. Maybe a total of ~10,000 users across all wikis? We can get a precise number from preferences data if we need to.
It performs well enough for beta deployment. If / when we enable it more broadly, I'd like to have a second look, for but for now: god speed!
(In reply to Ori Livneh from comment #7)
It performs well enough for beta deployment. If / when we enable it more
broadly, I'd like to have a second look, for but for now: god speed!
Noted. We won't deploy more broadly without a more thorough review. Thanks Ori!