Page MenuHomePhabricator

"view terms" link for permissions is broken in Firefox
Closed, ResolvedPublic

Details

Reference
bz61936

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:56 AM
bzimport added a project: MediaViewer.
bzimport set Reference to bz61936.
Tgr created this task.Feb 26 2014, 12:58 AM
Tgr added a comment.Feb 26 2014, 1:20 AM

jQuery's .hide().show() results in an inline display:block style in Firefox (in Chrome it is the correct display:inline). Looking at the source code, when the element is first hidden, Firefox gets the computed display style for the element, stores it as a data attribute and restores as an inline style when unhidden. Apparently, in this case "block" is stored instead of inline. Somehow related to hiding the element when it is not in the DOM (so jQuery cannot store data on it); switching the order of append and hide fixes it.

Change 115561 had a related patch set uploaded by Gergő Tisza:
Fix display issues with "view terms"

https://gerrit.wikimedia.org/r/115561

Change 115561 merged by jenkins-bot:
Fix display issues with "view terms"

https://gerrit.wikimedia.org/r/115561

Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:22 AM