Page MenuHomePhabricator

Clear:both for new table of contents doesn't work well with TOCRight template and divs with borders
Closed, InvalidPublic

Description

screenshot

See attached screenshot, or visit...
https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP
...with Typography Refresh turned on.


Version: unspecified
Severity: normal
URL: https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP

Attached:

Details

Reference
bz62026

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:02 AM
bzimport set Reference to bz62026.
bzimport added a subscriber: Unknown Object (MLST).
kaldari created this task.Feb 27 2014, 11:19 PM

Created attachment 14712
image of the page without issue.

Attached:

I'm not seeing this issue.

Confirm that I've got the same issue.

Looks like the content clears in Chrome, but not in Safari or Firefox.

Created attachment 14714
Failure in Chrome

Attached:

Created attachment 14715
Failure in Opera

Attached:

Nope, having the issue in all four of Chrome/Safari/Firefox/Opera.

That's weird. What browser are you using Jared?

Chrome Version 33.0.1750.117 beta OS X 10.8

I'm Chrome 33.0.1750.117 on OS X 10.8. I have no idea why Chrome would be clearing the TOC (it shouldn't), and even less idea why it isn't for James.

Reduced to simplest test case:

<div style="width: 20em; float: right;">
Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.
</div>

<h2 style="overflow: hidden; margin-left: -0.01em;">Header</h2>

Try loading the following page in different browsers and tell me what you get:
http://toolserver.org/~kaldari/bug62026.html

I see the header below the text in Chrome 33.0.1750.146, but next to the text in Firefox and Safari.

Change 117134 had a related patch set uploaded by Kaldari:
Removing negative margin for headers since it breaks Chrome :(

https://gerrit.wikimedia.org/r/117134

Change 117134 merged by Jdlrobson:
Removing negative margin for headers since it breaks Chrome :(

https://gerrit.wikimedia.org/r/117134

swalling wrote:

The beta feature for this no longer exists on master, and will be turned off next Tuesday/Thursday with the MediaWiki release. In the version committed to Vectore in core, the TOC change is not present.

FIXED -> INVALID as it… wasn't.

Just for the records...

The Chrome bug was reported at:
http://code.google.com/p/chromium/issues/detail?id=350473