Page MenuHomePhabricator

ResourceLoader: Change doesn't invalidate if change only touches a 'skinStyles' file
Closed, ResolvedPublic

Description

Applying the patch from Ie6b47f5d192953366911 in VisualEditor did not result in a module change update.

I kept refreshing and purging but nothing happened.

Turns out the way we fetch files in #getModifiedTime is broken for 'skinStyles'.

For some reason, this method duplicates the logic to interpret the 'skinStyles' array structure from #getStyleFiles (instead of using that method), and did so incorrectly causing it to always end up with an empty array.

The bug is quite subtle in that the module is capable of including these files (they're not missing from the css build), it's just that the module cache isn't invalidated if a commit only changed files listed in that part of a module.


Version: unspecified
Severity: normal

Details

Reference
bz62068

Event Timeline

bzimport raised the priority of this task from to Normal.Nov 22 2014, 3:05 AM
bzimport set Reference to bz62068.
Krinkle created this task.Feb 28 2014, 7:20 PM

Change 112837 had a related patch set uploaded by Krinkle:
resourceloader: Fix broken skinStyles loop in #getModifiedTime

https://gerrit.wikimedia.org/r/112837

Change 116143 had a related patch set uploaded by Krinkle:
[WIP] resourceloader: Regression test for bug 62068

https://gerrit.wikimedia.org/r/116143

Change 112837 merged by jenkins-bot:
resourceloader: Fix broken skinStyles loop in #getModifiedTime

https://gerrit.wikimedia.org/r/112837

Change 116143 abandoned by Krinkle:
[WIP] resourceloader: Regression test for bug 62068

https://gerrit.wikimedia.org/r/116143