Page MenuHomePhabricator
Create Task
Maniphest T64071

Edit link inconsistencies on Foreign file pages - skins which use doEditSectionLink incompatible with FileRepo
Closed, ResolvedPublic
Actions

Description

Navigate to https://commons.wikimedia.org/wiki/File:Apthorp_south_jeh.JPG
Now navigate to the same page via a ForeignAPI https://en.wikipedia.org/wiki/File:Apthorp_south_jeh.JPG

Notice that in the latter a broken VisualEditor link appears.
Expected: No VisualEditor link

Similarly if you go to the mobile site you will see the same problem - an edit link appears in square brackets rather than an edit icon (see bug 61807). The mobile skin uses doEditSectionLink which seems to be incompatible with FileRepo.

I've spent the morning talking with Brion to understand more about how the magic commons file page works and how the page is rendered.

Basically the problem is in FileRepo.php
getDescriptionRenderUrl creates an API request to something akin to https://commons.wikimedia.org/w/index.php?title=Image:Apthorp_south_jeh.JPG&action=render&uselang=en
If we can route this through the current skin this problem goes away.
e.g.
https://commons.wikimedia.org/w/index.php?title=Image:Apthorp_south_jeh.JPG&action=render&uselang=en&useformat=mobile
or
https://commons.wikimedia.org/w/index.php?title=Image:Apthorp_south_jeh.JPG&action=render&uselang=en&useskin=vector

Brion is taking a look to see if he can add a hook.

Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54259

Details

Reference
bz62071

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:05 AM
• bzimport added a project: MediaWiki-File-management.
• bzimport set Reference to bz62071.
• bzimport added a subscriber: Unknown Object (MLST).
Jdlrobson created this task.Feb 28 2014, 8:06 PM
Jdlrobson added a comment.Feb 28 2014, 8:07 PM

Apologies for the brain dump - I hope this is relatively clear.

matmarex added a comment.Feb 28 2014, 8:08 PM

That sounds like a VE/mobile bug, the links generated by core work just fine.

matmarex added a comment.Feb 28 2014, 8:09 PM

The VE bug for this is bug 54259.

Jdlrobson added a comment.Feb 28 2014, 9:42 PM

Thanks for clarifying the VE issue is a different problem.

Compare results of
https://commons.wikimedia.org/w/index.php?title=Image:Apthorp_south_jeh.JPG&action=render&uselang=en&useskin=vector
https://commons.wikimedia.org/w/index.php?title=Image:Apthorp_south_jeh.JPG&action=render&uselang=en&useformat=mobile
(triggers useskin=minerva but minerva is unregistered so this is needed)

The MinervaSkin overrides doEditSectionLink. There may be other skins that also override it and will thus be inconsistent.

matmarex added a comment.Mar 4 2014, 1:34 PM

Hmm. You seem to be requesting the same thing as bug 19415 here – I already tried to fix it once, but there were complications. There's a patch there that needs to be reworked.

(On a side note, my personal opinion about doEditSectionLink is that it should die in a fire and you should style the section edit links with CSS, as I made it possible to easily hide the brackets a few months ago.)

Jdlrobson added a comment.Mar 7 2014, 7:59 PM

Actually in the case of the file page we would like to render the edit links and make it possible to edit the content (albeit on a foreign wiki)

So really it would be great if this could just pass the current skin name along with the request..

MaxSem added a comment.Mar 11 2014, 8:14 PM

Making FileRepo stuff depend on current skin would be horrible, also there's a problem with permissions/being logged in on foreign wiki which makes displaying edit links unreliable. However, I redid Bartosz's fix for bug 19415 in https://gerrit.wikimedia.org/r/#/c/118135/

• Gilles added a project: Multimedia.Nov 24 2014, 3:33 PM
Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 4 2015, 6:36 PM
Restricted Application added subscribers: Steinsplitter, Matanya, Aklapper. · View Herald TranscriptSep 4 2015, 6:36 PM
MarkTraceur unsubscribed.Jan 27 2017, 10:11 PM
Restricted Application added a project: Commons. · View Herald TranscriptJan 27 2017, 10:11 PM
Jdlrobson mentioned this in T206546: Edit link is broken on file pages where magic commons is used.Oct 9 2018, 5:41 PM
matmarex added subtasks: T21415: Suppress section edit links with action=render, T206546: Edit link is broken on file pages where magic commons is used.Oct 18 2018, 3:13 AM
matmarex closed subtask T206546: Edit link is broken on file pages where magic commons is used as Resolved.Oct 18 2018, 9:05 PM
matmarex closed this task as Resolved.Oct 18 2018, 9:09 PM
In T64071#675063, @MaxSem wrote:

Making FileRepo stuff depend on current skin would be horrible, also there's a problem with permissions/being logged in on foreign wiki which makes displaying edit links unreliable. However, I redid Bartosz's fix for bug 19415 (T21415) in https://gerrit.wikimedia.org/r/#/c/118135/

Apparently, this never worked for File pages. I just fixed that with https://gerrit.wikimedia.org/r/468203. Since there will be no more section edit links in file descriptions fetched from foreign repo, I think we can consider this resolved.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL