Page MenuHomePhabricator

Flow: Small view and "This topic hidden" titlebars are misaligned after typography refresh
Closed, ResolvedPublic

Description

If you enable the Typography refresh beta feature and visit a Flow page, the "This topic was hidden by" text is misaligned vertically, appearing very low with descenders appearing outside the titlebar. See http://imgur.com/lLcMMyG .

Whether Flow should use h2 in titlebar and how much it should override h2 styling are open issues, see bug 59636.


Version: master
Severity: normal

Details

Reference
bz62073

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:05 AM
bzimport set Reference to bz62073.
bzimport added a subscriber: Unknown Object (MLST).

Need to retest with Gerrit change #116474 patch for bug 59636 which changes how posts render topic titlebar.

  • Bug 64193 has been marked as a duplicate of this bug. ***

Created attachment 15147
Flow screenshot of misaligned titlebar of deleted topic

Attached:

Also small view (the third icon) is messed up on mediawiki.org for both Firefox and chromium; I assume that's part of the same bug. It's not so bad on enwiki, so something in Flow or headers or button styling seems to be in 1.24 that wasn't in 1.23wmf22.

Created attachment 15154
bad text positioning of h2 in button titlebar in Small view

Attached:

Change 127858 had a related patch set uploaded by SG:
Fix topic hidden message when collapsed

https://gerrit.wikimedia.org/r/127858

Change 127858 merged by jenkins-bot:
Fix topic hidden message when collapsed

https://gerrit.wikimedia.org/r/127858

Change 127903 had a related patch set uploaded by Matthias Mullie:
Fix topic hidden message when collapsed

https://gerrit.wikimedia.org/r/127903

Change 127903 merged by jenkins-bot:
Fix topic hidden message when collapsed

https://gerrit.wikimedia.org/r/127903

Fixed and backported to 1.24wmf1.

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:39 AM