Page MenuHomePhabricator
Create Task
Maniphest T64087

Flow: no-JS "Reply" URL gives Unrecognized action error
Closed, ResolvedPublic
Actions

Description

Disable JavaScript and click a Reply button on a Flow page, e.g. http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&topic_postId=rpjlq7sbdswo8mjw&workflow=rpjlq7s9tmhzsdv0&action=reply , and you get a status 400 error page

The action specified by the URL is invalid ...

[dc92b61d] /w/index.php?title=Sandbox&topic_postId=rph87lzl1y8c56i4&workflow=rph87lzgdkxe4mcs&action=reply Exception from line 80 of /srv/mediawiki/extensions/Flow/includes/View.php: Unrecognized get action: reply

The quiet gray Reply button is redundant since each one is followed by an inline textarea with a [Reply] button, which works fine. We should pick one or the other, I vote for the quiet Reply button since all those textareas make Flow boards hard to read if you have JS disabled.

On mediawiki.org, instead of exception details and backtrace I see a pink errorbox, I assume that's a configuration difference in how errors are reported.

Version: master
Severity: minor
URL: http://ee-flow.wmflabs.org/w/index.php?title=Talk:Sandbox&topic_postId=rpjlq7sbdswo8mjw&workflow=rpjlq7s9tmhzsdv0&action=reply

Details

Reference
bz62087

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:06 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz62087.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Mar 1 2014, 12:47 AM
• Spage added a comment.Mar 5 2014, 7:42 PM

reply should be a valid action, something else is going on.

Maryana agrees it's probably better to only have the Reply button appear in no-JS instead of dozens of textareas and buttons. It would take you to the one topic with a textarea to make your reply.

matthiasmullie added a comment.Sep 5 2014, 2:29 PM

There no longer are textareas under every post to reply. Reply link now links to proper page, which then shows the textarea to reply.

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:40 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL